chrome/browser/resources/chromeos/login/gaia_header.js - Issue 1179323005: Polymer upgraded to 1.0 in login flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/gaia_header.js

Issue 1179323005: Polymer upgraded to 1.0 in login flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@polymer_pre_migration

Patch Set: Comments addressed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/login/controller-pairing-screen.html ('K') | « chrome/browser/resources/chromeos/login/gaia_header.html ('k') | chrome/browser/resources/chromeos/login/gaia_icon_button.css » ('j') | chrome/browser/resources/chromeos/login/gaia_input_form.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/gaia_header.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.js b/chrome/browser/resources/chromeos/login/gaia_header.js

similarity index 61%

copy from chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.js

copy to chrome/browser/resources/chromeos/login/gaia_header.js

index 1aa2b5cc2329414edb31880c10904ab4c4ddd7a8..7deb4f14792d6d53389a25d0ba0ce268bccad21c 100644

--- a/chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.js

+++ b/chrome/browser/resources/chromeos/login/gaia_header.js

@@ -3,5 +3,12 @@

// found in the LICENSE file.

Polymer({

- is: 'viewer-bookmarks-content'

+ is: 'gaia-header',

+ properties: {

+ email: {

+ type: String,

+ reflectToAttribute: true

michaelpg 2015/06/22 20:39:25 Does this need reflectToAttribute=true (what uses

dzhioev (left Google) 2015/06/22 21:17:44 Yep, this is not needed. At first I thought that '

+ }

});