chrome/browser/resources/chromeos/login/screen_gaia_signin.html - Issue 1179323005: Polymer upgraded to 1.0 in login flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

Issue 1179323005: Polymer upgraded to 1.0 in login flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@polymer_pre_migration

Patch Set: Comments addressed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/login/controller-pairing-screen.html ('K') | « chrome/browser/resources/chromeos/login/screen_gaia_signin.css ('k') | chrome/browser/resources/chromeos/login/screen_gaia_signin.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

index 6df41a0bdb23e02e2ee7445156972460a18fee1a..58f75f2dfdc6835696be5bce1d61a41bd7038c84 100644

--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

@@ -11,7 +11,7 @@

marginheight="0"

frameborder="0"

scrolling="no"></iframe>

- <offline-gaia id="offline-gaia" hidden></offline-gaia>

+ <offline-gaia id="offline-gaia" class="fit" hidden></offline-gaia>

</div>

@@ -35,8 +35,8 @@

<throbber-notice i18n-values="text:gaiaLoadingNewGaia"></throbber-notice>

</div>

<notification-card id="gaia-whitelist-error" type="fail"

- i18n-values="buttonLabel:tryAgainButton;

- linkLabel:learnMoreButton">

+ i18n-values="button-label:tryAgainButton;

+ link-label:learnMoreButton">

</notification-card>

@@ -44,8 +44,10 @@

</div>

- <button id="back-button-item" is="gaia-icon-button" icon="arrow-back" hidden

- i18n-values="aria-label:backButton" tabindex="0"></button>

- <button id="close-button-item" is="gaia-icon-button" icon="close" hidden

- i18n-values="aria-label:closeButton" tabindex="0"></button>

+ <gaia-icon-button id="back-button-item" icon="arrow-back" hidden

+ i18n-values="aria-label:backButton">

+ </gaia-icon-button>

+ <gaia-icon-button id="close-button-item" icon="close" hidden

+ i18n-values="aria-label:closeButton">

+ </gaia-icon-button>

</div>