Polymer upgraded to 1.0 in login flow.

Polymer upgraded to 1.0 in login flow.

Large changes:
* There are no filters in 1.0, that's why 'i18n' filters were replaced with
  'i18n-content' ({{'searching' | i18n}} -->
  i18n-content="login_ControllerPairingScreen_searching")
* <oobe-screen> wath replaced with OobeScreenBehavior, as 1.0 doesn't support
  inheritance.
* In 1.0 Polymer doesn't observe changes in properties which are Objects. That's
  why all context bindings ({{C.foo}}) stopped working. Created workaround for
  that problem (OobeScreenBehavior.registerBoundContextField).

Before and after versions are not totally equivalent: some styles and minor
issues were fixed.

(no presubmit because CSS checker doesn't understand CSS mixins)
BUG=489843
NOPRESUBMIT=true
TEST=existing tests

Committed: https://crrev.com/8b64c3b6e3842d90a81e0dcedbfde554ed03e9e4
Cr-Commit-Position: refs/heads/master@{#335774}

[dzhioev (left Google), 2015-06-16 21:24:09]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-16 21:25:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179323005/1

[commit-bot: I haz the power, 2015-06-16 21:36:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 21:36:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dzhioev (left Google), 2015-06-16 21:48:02]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-16 21:48:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179323005/1

[dzhioev (left Google), 2015-06-17 23:39:38]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-17 23:41:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179323005/40001

[commit-bot: I haz the power, 2015-06-17 23:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 23:56:03]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dzhioev (left Google), 2015-06-18 00:58:58]

dzhioev@chromium.org changed reviewers:
+ rsorokin@chromium.org

[dzhioev (left Google), 2015-06-18 01:09:37]

Roman, please review.

You probably want to read migration guide before starting review
(https://www.polymer-project.org/1.0/docs/migration.html).

Also I implemented several isolated html pages, to compare Polymer 0.5 and 1.0
implementations of the elements. You can find them here http://dzhioev.net:8888.

Thanks

[dzhioev (left Google), 2015-06-18 01:19:04]

dzhioev@chromium.org changed reviewers:
+ jhawkins@chromium.org

[dzhioev (left Google), 2015-06-18 01:19:05]

+jhawkins@

James, please review chrome/browser/browser_resources.grd

[James Hawkins, 2015-06-18 16:41:20]

lgtm

[Roman Sorokin (ftl), 2015-06-19 13:10:32]

In the new version on incorrect input red warning triangle does not appear on
the right side (e.g. here
http://dzhioev.net:8888/migration/data/side_by_side_test_runner.html#gaia_input)

In the new version here
http://dzhioev.net:8888/migration/data/side_by_side_test_runner.html#offline_...
Back button does not hide right away after clicking.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:47: <div
class="flex horizontal end-justified layout center">
Why do you use classes for layout attributes? In the guide they propose
@apply(--layout-horizontal) in css.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:111:
<neon-animated-pages id="pages" selected="{{C.page}}"
nit: Indentation

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:257:
</paper-shadow>
Is it closing <paper-material>?

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.js
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.js:13:
devices: Array,
nit: Add an empty string

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.js:17: },
ditto

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_buttons.html (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_buttons.html:29:
on-focused-changed="focusedChanged_" tabindex="0">
Is tabindex obsolete here?

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_card.css (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_card.css:7: display: flex;
Why do you use css for layout attributes here and class="layout..." in other
places?

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/notification_card.js (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/notification_card.js:11: value: ''
Won't it be empty by default?

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.css
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.css:56: 
nit: Please remove empty line

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_confirm_password.html (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_confirm_password.html:51: <div
class="footer gaia-body-text horizontal layout center">
Layout attributes should be declared in css as
@apply(--layout-horizontal)

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_confirm_password.html:75:
<paper-dialog id="cancelConfirmDlg" no-cancel-on-outside-click
Why is it no-cancel-on-outside?

[dzhioev (left Google), 2015-06-20 02:01:55]

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:47: <div
class="flex horizontal end-justified layout center">
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Why do you use classes for layout attributes? In the guide they propose
> @apply(--layout-horizontal) in css.

There is another way: use layout classes instead of layout attributes
(https://github.com/PolymerElements/iron-flex-layout/blob/master/classes/iron-...).
To keep this CL simpler, I've chosen this option. I'm going to replace this
classes with custom attributes (i.e. @apply(...)) later.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:111:
<neon-animated-pages id="pages" selected="{{C.page}}"
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> nit: Indentation

Done.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:257:
</paper-shadow>
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Is it closing <paper-material>?

Nice catch. Done.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.js
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.js:13:
devices: Array,
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> nit: Add an empty string

Done.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.js:17: },
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> ditto

Done.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_buttons.html (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_buttons.html:29:
on-focused-changed="focusedChanged_" tabindex="0">
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Is tabindex obsolete here?

Yep. <paper-button> sets tabindex by itself.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_card.css (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_card.css:7: display: flex;
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Why do you use css for layout attributes here and class="layout..." in other
> places?

I only do this for ":host".

For 0.5 it was like:
<polymer-element name="x-foo" horizontal layout>
</polymer-element>

In 1.0 I could have made something like this:
Polymer({
  is: 'x-foo',
  hostAttributes: {
    class: 'horizontal layout'
  }
});

and this will work for a simple case like:
<x-foo></x-foo>

However if we set "class" property for the element:
<x-foo class="my-x-foo"></x-foo>

its value completely replace the value set in |hostAttributes|.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/notification_card.js (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/notification_card.js:11: value: ''
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Won't it be empty by default?

No, it's undefined by default, and if it is undefined, bindings like
hidden$="[[!buttonLabel]]" don't work.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.css
(right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.css:56: 
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> nit: Please remove empty line

I'm not sure about that. Some CSS files have empty line in the EOF, some not.
This file had empty line before my change.

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_confirm_password.html (right):

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_confirm_password.html:51: <div
class="footer gaia-body-text horizontal layout center">
On 2015/06/19 13:10:32, Roman Sorokin wrote:
> Layout attributes should be declared in css as
> @apply(--layout-horizontal)

ditto

https://codereview.chromium.org/1179323005/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_confirm_password.html:75:
<paper-dialog id="cancelConfirmDlg" no-cancel-on-outside-click
On 2015/06/19 13:10:31, Roman Sorokin wrote:
> Why is it no-cancel-on-outside?

This dialog is multi-choice. I believe we shouldn't make it auto closing in this
case, because it is not obvious which choice is default. Not 100% sure though.

[dzhioev (left Google), 2015-06-22 19:08:24]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[dzhioev (left Google), 2015-06-22 19:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org
Link to the patchset: https://codereview.chromium.org/1179323005/#ps60001
(title: "Comments addressed.")

[commit-bot: I haz the power, 2015-06-22 19:10:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179323005/60001

[commit-bot: I haz the power, 2015-06-22 20:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 20:33:48]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2015-06-22 20:39:24]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2015-06-22 20:39:25]

Just a couple drive-by comments.

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:31: <link
rel="stylesheet" href="pairing_device_list.css">
This imports the stylesheet as a regular stylesheet to apply to the document.
Polymer 1.0 has a specific way to scope stylesheets to the element being
defined:

<link rel="import" type="css" href="pairing_device_list.css">

https://www.polymer-project.org/1.0/docs/devguide/styling.html

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_header.js (right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_header.js:11: reflectToAttribute:
true
Does this need reflectToAttribute=true (what uses it?)

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_input_form.js (right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_input_form.js:16:
reflectToAttribute: true
Why does this need reflectToAttribute?

[dzhioev (left Google), 2015-06-22 21:17:44]

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:31: <link
rel="stylesheet" href="pairing_device_list.css">
On 2015/06/22 20:39:24, michaelpg wrote:
> This imports the stylesheet as a regular stylesheet to apply to the document.
> Polymer 1.0 has a specific way to scope stylesheets to the element being
> defined:
> 
> <link rel="import" type="css" href="pairing_device_list.css">
> 
> https://www.polymer-project.org/1.0/docs/devguide/styling.html

I know that. However all CSS imports in OOBE are inlined by GRIT at compile
time, and GRIT only understands <link rel="stylesheet"> syntax.
It was discussed already in
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-polymer/DGEaA...

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_header.js (right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_header.js:11: reflectToAttribute:
true
On 2015/06/22 20:39:25, michaelpg wrote:
> Does this need reflectToAttribute=true (what uses it?)

Yep, this is not needed. At first I thought that 'reflectToAttribute' is needed
for setting attributes from HTML (<x-foo foo="bar"></x-foo>).
Removed.

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/gaia_input_form.js (right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/gaia_input_form.js:16:
reflectToAttribute: true
On 2015/06/22 20:39:25, michaelpg wrote:
> Why does this need reflectToAttribute?

it doesn't. Removed.

[Roman Sorokin (ftl), 2015-06-23 11:50:32]

In the new version on incorrect input red warning triangle does not appear on
the right side (e.g. here
http://dzhioev.net:8888/migration/data/side_by_side_test_runner.html#gaia_input)

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/host-pairing-screen.html (right):

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/host-pairing-screen.html:20: <include
src="../../../../app/theme/cast_icon.svg">
Please restore all the closing tags.

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/offline_gaia.js (right):

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_gaia.js:35:
this.$.backButton.hidden = this.isEmailSectionActive_();
It is not equivalent to previous version. Before it hided backButton before
animation started. In this version one could click backButton multiple times

[Roman Sorokin (ftl), 2015-06-23 19:57:11]

On 2015/06/23 11:50:32, Roman Sorokin wrote:
> In the new version on incorrect input red warning triangle does not appear on
> the right side (e.g. here
>
http://dzhioev.net:8888/migration/data/side_by_side_test_runner.html#gaia_input)
> 
>
https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/login/host-pairing-screen.html (right):
> 
>
https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
> chrome/browser/resources/chromeos/login/host-pairing-screen.html:20: <include
> src="../../../../app/theme/cast_icon.svg">
> Please restore all the closing tags.
> 
>
https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/login/offline_gaia.js (right):
> 
>
https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
> chrome/browser/resources/chromeos/login/offline_gaia.js:35:
> this.$.backButton.hidden = this.isEmailSectionActive_();
> It is not equivalent to previous version. Before it hided backButton before
> animation started. In this version one could click backButton multiple times

lgtm

[dzhioev (left Google), 2015-06-23 20:10:11]

<paper-input> doesn't have triangle icon anymore. GAIA's inputs doesn't have the
icon as well, so I think that's fine.

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/host-pairing-screen.html (right):

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/host-pairing-screen.html:20: <include
src="../../../../app/theme/cast_icon.svg">
On 2015/06/23 11:50:32, Roman Sorokin wrote:
> Please restore all the closing tags.

Done.

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/offline_gaia.js (right):

https://codereview.chromium.org/1179323005/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_gaia.js:35:
this.$.backButton.hidden = this.isEmailSectionActive_();
On 2015/06/23 11:50:32, Roman Sorokin wrote:
> It is not equivalent to previous version. Before it hided backButton before
> animation started. In this version one could click backButton multiple times

Done. Added code hiding the button to onBack_()

[dzhioev (left Google), 2015-06-23 20:15:08]

The CQ bit was checked by dzhioev@chromium.org

[dzhioev (left Google), 2015-06-23 20:15:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org, rsorokin@chromium.org
Link to the patchset: https://codereview.chromium.org/1179323005/#ps110001
(title: "Comments addressed.")

[commit-bot: I haz the power, 2015-06-23 20:16:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179323005/110001

[michaelpg, 2015-06-23 21:46:38]

michaelpg@chromium.org changed reviewers:
- michaelpg@chromium.org

[michaelpg, 2015-06-23 21:46:39]

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:31: <link
rel="stylesheet" href="pairing_device_list.css">
On 2015/06/22 21:17:44, dzhioev wrote:
> On 2015/06/22 20:39:24, michaelpg wrote:
> > This imports the stylesheet as a regular stylesheet to apply to the
document.
> > Polymer 1.0 has a specific way to scope stylesheets to the element being
> > defined:
> > 
> > <link rel="import" type="css" href="pairing_device_list.css">
> > 
> > https://www.polymer-project.org/1.0/docs/devguide/styling.html
> 
> I know that. However all CSS imports in OOBE are inlined by GRIT at compile
> time, and GRIT only understands <link rel="stylesheet"> syntax.
> It was discussed already in
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-polymer/DGEaA...

My bad, I remember that now. Thanks!

https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
(right):

https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/controller-pairing-screen.html:115:
i18n-content="login_ControllerPairingScreen_welcomeTitle">
This will trigger presubmit warnings in future patches: i18n keys should use
javaScriptCase. I don't want it to hold up the migration, but can you add a TODO
or point me to a bug if there is one? I know these keys were set
programmatically before so I dunno if this came up then.

[commit-bot: I haz the power, 2015-06-23 22:23:10]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2015-06-23 22:24:37]

Patchset 7 (id:??) landed as
https://crrev.com/8b64c3b6e3842d90a81e0dcedbfde554ed03e9e4
Cr-Commit-Position: refs/heads/master@{#335774}

[dzhioev (left Google), 2015-06-23 22:40:16]

On 2015/06/23 21:46:39, michaelpg wrote:
>
https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
> (right):
> 
>
https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
> chrome/browser/resources/chromeos/login/controller-pairing-screen.html:31:
<link
> rel="stylesheet" href="pairing_device_list.css">
> On 2015/06/22 21:17:44, dzhioev wrote:
> > On 2015/06/22 20:39:24, michaelpg wrote:
> > > This imports the stylesheet as a regular stylesheet to apply to the
> document.
> > > Polymer 1.0 has a specific way to scope stylesheets to the element being
> > > defined:
> > > 
> > > <link rel="import" type="css" href="pairing_device_list.css">
> > > 
> > > https://www.polymer-project.org/1.0/docs/devguide/styling.html
> > 
> > I know that. However all CSS imports in OOBE are inlined by GRIT at compile
> > time, and GRIT only understands <link rel="stylesheet"> syntax.
> > It was discussed already in
> >
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-polymer/DGEaA...
> 
> My bad, I remember that now. Thanks!
> 
>
https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
> (right):
> 
>
https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/controller-pairing-screen.html:115:
> i18n-content="login_ControllerPairingScreen_welcomeTitle">
> This will trigger presubmit warnings in future patches: i18n keys should use
> javaScriptCase. I don't want it to hold up the migration, but can you add a
TODO
> or point me to a bug if there is one? I know these keys were set
> programmatically before so I dunno if this came up then.

Yep, I saw those warnings, but decided to ignore them for now.

I had some thoughts about reimplementing "namespacing" feature for 1.0. In my
thoughts there should be a behavior, which'll map translated strings to its
properties, allowing to make things similar to what 'i18n' filter did.
Something like:

<dom-module name="x-foo">
  <template>
    <span>{{S.welcomeTitle}}</span>
  </template>
</dom-module>

...

Polymer({
  is: 'x-foo',
  behaviors: [ new I18nBehavior('login_ControllerPairing') ]
});


But I'm not sure that it's worth the effort. Only two screens in the Oobe UI are
using
this "namespacing" feature, and we are not going to change them or add new
screens anytime
soon. However I would implemented such thing, if other WebUI folks were
interested in it.

[michaelpg, 2015-06-24 00:23:05]

On 2015/06/23 22:40:16, dzhioev wrote:
> On 2015/06/23 21:46:39, michaelpg wrote:
> >
>
https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
> > File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/1179323005/diff/60001/chrome/browser/resource...
> > chrome/browser/resources/chromeos/login/controller-pairing-screen.html:31:
> <link
> > rel="stylesheet" href="pairing_device_list.css">
> > On 2015/06/22 21:17:44, dzhioev wrote:
> > > On 2015/06/22 20:39:24, michaelpg wrote:
> > > > This imports the stylesheet as a regular stylesheet to apply to the
> > document.
> > > > Polymer 1.0 has a specific way to scope stylesheets to the element being
> > > > defined:
> > > > 
> > > > <link rel="import" type="css" href="pairing_device_list.css">
> > > > 
> > > > https://www.polymer-project.org/1.0/docs/devguide/styling.html
> > > 
> > > I know that. However all CSS imports in OOBE are inlined by GRIT at
compile
> > > time, and GRIT only understands <link rel="stylesheet"> syntax.
> > > It was discussed already in
> > >
> >
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-polymer/DGEaA...
> > 
> > My bad, I remember that now. Thanks!
> > 
> >
>
https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
> > File chrome/browser/resources/chromeos/login/controller-pairing-screen.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/1179323005/diff/110001/chrome/browser/resourc...
> > chrome/browser/resources/chromeos/login/controller-pairing-screen.html:115:
> > i18n-content="login_ControllerPairingScreen_welcomeTitle">
> > This will trigger presubmit warnings in future patches: i18n keys should use
> > javaScriptCase. I don't want it to hold up the migration, but can you add a
> TODO
> > or point me to a bug if there is one? I know these keys were set
> > programmatically before so I dunno if this came up then.
> 
> Yep, I saw those warnings, but decided to ignore them for now.
> 
> I had some thoughts about reimplementing "namespacing" feature for 1.0. In my
> thoughts there should be a behavior, which'll map translated strings to its
> properties, allowing to make things similar to what 'i18n' filter did.
> Something like:
> 
> <dom-module name="x-foo">
>   <template>
>     <span>{{S.welcomeTitle}}</span>
>   </template>
> </dom-module>
> 
> ...
> 
> Polymer({
>   is: 'x-foo',
>   behaviors: [ new I18nBehavior('login_ControllerPairing') ]
> });
> 
> 
> But I'm not sure that it's worth the effort. Only two screens in the Oobe UI
are
> using
> this "namespacing" feature, and we are not going to change them or add new
> screens anytime
> soon. However I would implemented such thing, if other WebUI folks were
> interested in it.

I think we do need to figure something out for WebUI in general. Sounds like
you might be volunteering? :-)

One other thing I just noticed -- some of these HTML files have copyright
headers.
I don't think we usually add the license headers to HTML files, for whatever
reason.