content/browser/renderer_host/media/video_capture_controller.cc - Issue 1179323002: Video Capture: extract storage info from pixel format in VideoCaptureFormat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 1179323002: Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: second round of comments from hubbe@. Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/capture/aura_window_capture_machine.cc ('K') | « content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_controller_unittest.cc » ('j') | media/base/video_capture_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc

index 05636438f151b3fe0827ba6b64f9b6077ffc5e2b..41ccb69f1e981a0cfef4b7d440b1347ecba39129 100644

--- a/content/browser/renderer_host/media/video_capture_controller.cc

+++ b/content/browser/renderer_host/media/video_capture_controller.cc

@@ -328,7 +328,9 @@ void VideoCaptureController::DoIncomingCapturedVideoFrameOnIOThread(

client->controller_id, buffer_id, frame->mailbox_holder(0),

frame->coded_size(), timestamp, copy_of_metadata.Pass());

} else if (frame->format() == media::VideoFrame::I420) {

- bool is_new_buffer = client->known_buffers.insert(buffer_id).second;

+ DCHECK(frame->IsMappable());

+ const bool is_new_buffer =

+ client->known_buffers.insert(buffer_id).second;

if (is_new_buffer) {

// On the first use of a buffer on a client, share the memory handle.

size_t memory_size = 0;