content/browser/media/capture/web_contents_video_capture_device_unittest.cc - Issue 1179323002: Video Capture: extract storage info from pixel format in VideoCaptureFormat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

Issue 1179323002: Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: second round of comments from hubbe@. Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/capture/aura_window_capture_machine.cc ('K') | « content/browser/media/capture/desktop_capture_device_unittest.cc ('k') | content/browser/media/media_internals_unittest.cc » ('j') | media/base/video_capture_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

index ac97158185fff94a1635fad8b373ddaf61ac250d..90b859629b22518c1bf4a5b51ec8e21d7688198a 100644

--- a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

@@ -347,12 +347,13 @@ class StubClient : public media::VideoCaptureDevice::Client {

MOCK_METHOD0(DoOnIncomingCapturedBuffer, void(void));

scoped_ptr<media::VideoCaptureDevice::Client::Buffer> ReserveOutputBuffer(

+ const gfx::Size& dimensions,

media::VideoPixelFormat format,

- const gfx::Size& dimensions) override {

+ media::VideoPixelStorage storage) override {

CHECK_EQ(format, media::PIXEL_FORMAT_I420);

int buffer_id_to_drop = VideoCaptureBufferPool::kInvalidId; // Ignored.

- int buffer_id = buffer_pool_->ReserveForProducer(format, dimensions,

- &buffer_id_to_drop);

+ const int buffer_id = buffer_pool_->ReserveForProducer(

+ format, storage, dimensions, &buffer_id_to_drop);

if (buffer_id == VideoCaptureBufferPool::kInvalidId)

return NULL;