Video Capture: extract storage info from pixel format in VideoCaptureFormat.

content/browser/renderer_host/media/video_capture_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 310 matching lines @@
         copy_of_metadata.reset(metadata->DeepCopy());
 
       if (frame->HasTextures()) {
         DCHECK(frame->coded_size() == frame->visible_rect().size())
             << "Textures are always supposed to be tightly packed.";
         DCHECK_EQ(1u, VideoFrame::NumPlanes(frame->format()));
         client->event_handler->OnMailboxBufferReady(
             client->controller_id, buffer_id, frame->mailbox_holder(0),
             frame->coded_size(), timestamp, copy_of_metadata.Pass());
       } else if (frame->format() == media::VideoFrame::I420) {
-        bool is_new_buffer = client->known_buffers.insert(buffer_id).second;
+        DCHECK(frame->IsMappable());
+        const bool is_new_buffer =
+            client->known_buffers.insert(buffer_id).second;
         if (is_new_buffer) {
           // On the first use of a buffer on a client, share the memory handle.
           size_t memory_size = 0;
           base::SharedMemoryHandle remote_handle = buffer_pool_->ShareToProcess(
               buffer_id, client->render_process_handle, &memory_size);
           client->event_handler->OnBufferCreated(
               client->controller_id, remote_handle, memory_size, buffer_id);
         }
 
         client->event_handler->OnBufferReady(
             client->controller_id, buffer_id, frame->coded_size(),
             frame->visible_rect(), timestamp, copy_of_metadata.Pass());
       } else {
         // VideoFrame format not supported.
         NOTREACHED() << media::VideoFrame::FormatToString(frame->format());
         break;
       }
 
-      bool inserted =
+      const bool inserted =
           client->active_buffers.insert(std::make_pair(buffer_id, frame))
               .second;
       DCHECK(inserted) << "Unexpected duplicate buffer: " << buffer_id;
       count++;
     }
   }
 
   if (!has_received_frames_) {
     UMA_HISTOGRAM_COUNTS("Media.VideoCapture.Width",
                          frame->visible_rect().width());
     UMA_HISTOGRAM_COUNTS("Media.VideoCapture.Height",
                          frame->visible_rect().height());
     UMA_HISTOGRAM_ASPECT_RATIO("Media.VideoCapture.AspectRatio",
                                frame->visible_rect().width(),
                                frame->visible_rect().height());
-    double frame_rate;
+    double frame_rate = 0.0f;
     if (!frame->metadata()->GetDouble(media::VideoFrameMetadata::FRAME_RATE,
-                                      &frame_rate))
+                                      &frame_rate)) {
       frame_rate = video_capture_format_.frame_rate;
+    }
     UMA_HISTOGRAM_COUNTS("Media.VideoCapture.FrameRate", frame_rate);
     has_received_frames_ = true;
   }
 
   buffer_pool_->HoldForConsumers(buffer_id, count);
 }
 
 void VideoCaptureController::DoErrorOnIOThread() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   state_ = VIDEO_CAPTURE_STATE_ERROR;
@@ skipping 55 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   int active_client_count = 0;
   for (ControllerClient* client : controller_clients_) {
     if (!client->paused)
       ++active_client_count;
   }
   return active_client_count;
 }
 
 }  // namespace content