Video Capture: extract storage info from pixel format in VideoCaptureFormat.

media/base/video_capture_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_CAPTURE_TYPES_H_
 #define MEDIA_BASE_VIDEO_CAPTURE_TYPES_H_
 
 #include <vector>
 
 #include "media/base/media_export.h"
@@ skipping 10 matching lines @@
   PIXEL_FORMAT_I420,
   PIXEL_FORMAT_YV12,
   PIXEL_FORMAT_NV12,
   PIXEL_FORMAT_NV21,
   PIXEL_FORMAT_UYVY,
   PIXEL_FORMAT_YUY2,
   PIXEL_FORMAT_RGB24,
   PIXEL_FORMAT_RGB32,
   PIXEL_FORMAT_ARGB,
   PIXEL_FORMAT_MJPEG,
-  PIXEL_FORMAT_TEXTURE,  // Capture format as a GL texture.
-  PIXEL_FORMAT_GPUMEMORYBUFFER,
   PIXEL_FORMAT_UNKNOWN,  // Color format not set.
   PIXEL_FORMAT_MAX,
 };
 
+enum VideoPixelStorage {
+  PIXEL_STORAGE_CPU,
+  PIXEL_STORAGE_TEXTURE,

[hubbe, 2015/06/16 21:11:35]

Does PIXEL_FORMAT_???? make any sense if the storage is a texture?
Please add some comments to explain the semantics.

[mcasas, 2015/06/16 23:14:01]

Done.

+  PIXEL_STORAGE_GPUMEMORYBUFFER,
+};
+
 // Policies for capture devices that have source content that varies in size.
 // It is up to the implementation how the captured content will be transformed
 // (e.g., scaling and/or letterboxing) in order to produce video frames that
 // strictly adheree to one of these policies.
 enum ResolutionChangePolicy {
   // Capture device outputs a fixed resolution all the time. The resolution of
   // the first frame is the resolution for all frames.
   RESOLUTION_POLICY_FIXED_RESOLUTION,
 
   // Capture device is allowed to output frames of varying resolutions. The
@@ skipping 16 matching lines @@
 // Video capture format specification.
 // This class is used by the video capture device to specify the format of every
 // frame captured and returned to a client. It is also used to specify a
 // supported capture format by a device.
 class MEDIA_EXPORT VideoCaptureFormat {
  public:
   VideoCaptureFormat();
   VideoCaptureFormat(const gfx::Size& frame_size,
                      float frame_rate,
                      VideoPixelFormat pixel_format);
+  VideoCaptureFormat(const gfx::Size& frame_size,
+                     float frame_rate,
+                     VideoPixelFormat pixel_format,
+                     VideoPixelStorage pixel_storage);
 
   std::string ToString() const;
   static std::string PixelFormatToString(VideoPixelFormat format);
+  static std::string PixelStorageToString(VideoPixelStorage storage);
 
   // Returns the required buffer size to hold an image of a given
   // VideoCaptureFormat with no padding and tightly packed.
   size_t ImageAllocationSize() const;
 
   // Checks that all values are in the expected range. All limits are specified
   // in media::Limits.
   bool IsValid() const;
 
   bool operator==(const VideoCaptureFormat& other) const {
     return frame_size == other.frame_size &&
         frame_rate == other.frame_rate &&
         pixel_format == other.pixel_format;
   }
 
   gfx::Size frame_size;
   float frame_rate;
   VideoPixelFormat pixel_format;
+  VideoPixelStorage pixel_storage;
 };
 
 typedef std::vector<VideoCaptureFormat> VideoCaptureFormats;
 
 // Parameters for starting video capture.
 // This class is used by the client of a video capture device to specify the
 // format of frames in which the client would like to have captured frames
 // returned.
 class MEDIA_EXPORT VideoCaptureParams {
  public:
   VideoCaptureParams();
 
   bool operator==(const VideoCaptureParams& other) const {
     return requested_format == other.requested_format &&
         resolution_change_policy == other.resolution_change_policy;
   }
 
   // Requests a resolution and format at which the capture will occur.
   VideoCaptureFormat requested_format;
 
   // Policy for resolution change.
   ResolutionChangePolicy resolution_change_policy;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_VIDEO_CAPTURE_TYPES_H_