Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceCompiler.cpp

Issue 1179313004: Fix a bug that would cause subzero to fail when --threads=0. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses code review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceCompiler.cpp
diff --git a/src/IceCompiler.cpp b/src/IceCompiler.cpp
index 2db7abcda95ef96d39521b435d9320e92fb5d0f2..76c3a38616ff7100b24f9dc39da73e0000d19cee 100644
--- a/src/IceCompiler.cpp
+++ b/src/IceCompiler.cpp
@@ -141,8 +141,13 @@ void Compiler::run(const Ice::ClFlagsExtra &ExtraFlags, GlobalContext &Ctx,
}
Ctx.waitForWorkerThreads();
- Translator->transferErrorCode();
- Translator->emitConstants();
+ if (Translator->getErrorStatus()) {
+ Ctx.getErrorStatus()->assign(Translator->getErrorStatus().value());
+ } else {
+ Ctx.lowerGlobals("last");
+ Ctx.lowerProfileData();
+ Ctx.lowerConstants();
+ }
if (Ctx.getFlags().getOutFileType() == FT_Elf) {
TimerMarker T1(Ice::TimerStack::TT_emit, &Ctx);
« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceELFObjectWriter.h » ('j') | src/IceELFObjectWriter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698