Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: src/IceTargetLoweringX8632.h

Issue 1179313004: Fix a bug that would cause subzero to fail when --threads=0. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses code review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 //===- subzero/src/IceTargetLoweringX8632.h - x86-32 lowering ---*- C++ -*-===// 1 //===- subzero/src/IceTargetLoweringX8632.h - x86-32 lowering ---*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the TargetLoweringX8632 class, which 10 // This file declares the TargetLoweringX8632 class, which
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 class TargetDataX8632 final : public TargetDataLowering { 580 class TargetDataX8632 final : public TargetDataLowering {
581 TargetDataX8632() = delete; 581 TargetDataX8632() = delete;
582 TargetDataX8632(const TargetDataX8632 &) = delete; 582 TargetDataX8632(const TargetDataX8632 &) = delete;
583 TargetDataX8632 &operator=(const TargetDataX8632 &) = delete; 583 TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
584 584
585 public: 585 public:
586 static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) { 586 static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
587 return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx)); 587 return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
588 } 588 }
589 589
590 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override; 590 void lowerGlobals(const VariableDeclarationList &Vars,
591 void lowerConstants() override; 591 const IceString &SectionSuffix) override;
592 void lowerConstants(const IceString &SectionSuffix) override;
592 593
593 protected: 594 protected:
594 explicit TargetDataX8632(GlobalContext *Ctx); 595 explicit TargetDataX8632(GlobalContext *Ctx);
595 596
596 private: 597 private:
597 ~TargetDataX8632() override {} 598 ~TargetDataX8632() override {}
598 template <typename T> static void emitConstantPool(GlobalContext *Ctx); 599 template <typename T> static void emitConstantPool(GlobalContext *Ctx);
599 }; 600 };
600 601
601 class TargetHeaderX8632 final : public TargetHeaderLowering { 602 class TargetHeaderX8632 final : public TargetHeaderLowering {
602 TargetHeaderX8632() = delete; 603 TargetHeaderX8632() = delete;
603 TargetHeaderX8632(const TargetHeaderX8632 &) = delete; 604 TargetHeaderX8632(const TargetHeaderX8632 &) = delete;
604 TargetHeaderX8632 &operator=(const TargetHeaderX8632 &) = delete; 605 TargetHeaderX8632 &operator=(const TargetHeaderX8632 &) = delete;
605 606
606 public: 607 public:
607 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) { 608 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
608 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderX8632(Ctx)); 609 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderX8632(Ctx));
609 } 610 }
610 611
611 protected: 612 protected:
612 explicit TargetHeaderX8632(GlobalContext *Ctx); 613 explicit TargetHeaderX8632(GlobalContext *Ctx);
613 614
614 private: 615 private:
615 ~TargetHeaderX8632() = default; 616 ~TargetHeaderX8632() = default;
616 }; 617 };
617 618
618 } // end of namespace Ice 619 } // end of namespace Ice
619 620
620 #endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H 621 #endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698