Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

Issue 1179283007: add for() keyword suggestion (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
index 99c9ce31bd3fbde43a4d5736b9917fb5f9a31ca3..33dfa582edeafd2d34cab6c3e9cdd7616e9da28f 100644
--- a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
@@ -375,7 +375,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
Keyword.CONTINUE,
Keyword.DO,
Keyword.FINAL,
- Keyword.FOR,
+ //Keyword.FOR,
Keyword.IF,
Keyword.NEW,
Keyword.RETURN,
@@ -386,6 +386,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
Keyword.VOID,
Keyword.WHILE
]);
+ _addSuggestion2('for ()', offset: 5);
_addSuggestion(Keyword.RETHROW, DART_RELEVANCE_KEYWORD - 1);
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698