Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(105)

Issue 1179263003: ViewPainter should skip painting if not inside painting subtree (Closed)

Created:
4 years, 10 months ago by trchen
Modified:
4 years, 10 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ViewPainter should skip painting if not inside painting subtree As with other layout objects, ViewPainter should respect paintInfo.paintingRoot as well, which is used by drag & drop code to generate drag image of a single element. BUG=499728 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
A + LayoutTests/fast/images/drag-image-2.html View 1 chunk +12 lines, -5 lines 0 comments Download
A LayoutTests/fast/images/drag-image-2-expected.png View Binary file 0 comments Download
A + LayoutTests/fast/images/drag-image-2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/images/resources/grid-transparent.png View Binary file 0 comments Download
M Source/core/paint/ViewPainter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
trchen
4 years, 10 months ago (2015-06-12 22:54:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179263003/1
4 years, 10 months ago (2015-06-12 22:54:49 UTC) #4
trchen
Note: the expected image has a black background because test runner doesn't save alpha channel ...
4 years, 10 months ago (2015-06-12 22:56:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-13 01:52:04 UTC) #7
trchen
Ding dong
4 years, 10 months ago (2015-06-16 04:06:40 UTC) #8
Xianzhu
lgtm
4 years, 10 months ago (2015-06-16 04:42:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179263003/1
4 years, 10 months ago (2015-06-16 04:43:03 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 06:06:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197157

Powered by Google App Engine
This is Rietveld 408576698