Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1179213002: Fixing stripe test (Closed)

Created:
5 years, 6 months ago by msarett
Modified:
5 years, 6 months ago
Reviewers:
scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixing stripe test I originally thought that there was no harm in reading or skipping zero lines after we have already reached the end of the image. However, once we reach the end of the image, onFinish() is automatically called. Performing a read or a skip after the call to onFinish() is invalid and will cause onFinish() to be called a second time (which is also invalid). Seems like the code requires good behavior and the test is wrong. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f6db27e58e65a4c9680fdf00e41047578b6ac9f9

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
msarett
5 years, 6 months ago (2015-06-12 15:47:31 UTC) #2
scroggo
lgtm
5 years, 6 months ago (2015-06-12 16:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179213002/20001
5 years, 6 months ago (2015-06-12 16:28:34 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 16:34:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/f6db27e58e65a4c9680fdf00e41047578b6ac9f9

Powered by Google App Engine
This is Rietveld 408576698