Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 11792002: Whenever we set plain text on the standard clipboard, also set (Closed)

Created:
7 years, 11 months ago by tony
Modified:
7 years, 11 months ago
Reviewers:
Elliot Glaysher, dcheng
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

Whenever we set plain text on the standard clipboard, also set the selection clipboard on Linux. Most of the time, this happens automatically since the only way to set the standard clipboard is to select text (which sets the selection clipboard), but it's possible to set the standard clipboard using javascript (event.clipboardData.setData('text/plain', ...)). Since we always set the selection clipboard, I removed some code that was for handling the "Copy Link Address" context menu item. I tested on GTK+ and Aura. BUG=168135 TEST=Right click a link, select "Copy Link Addres", middle click in a text field. This should paste the URL. Here's a test case for clipboardData.setData: http://jsfiddle.net/LNWMG/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M ui/base/clipboard/clipboard.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M ui/base/clipboard/clipboard_gtk.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
7 years, 11 months ago (2013-01-04 21:52:53 UTC) #1
Elliot Glaysher
lgtm
7 years, 11 months ago (2013-01-04 22:02:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11792002/1
7 years, 11 months ago (2013-01-07 17:35:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 19:23:58 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 20:02:32 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698