Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 1179183002: DevTools: border and toolbar colors from Max's mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review comments addressed. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Eve ntListener) { 246 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Eve ntListener) {
247 var eventName = details.auxData["eventName"]; 247 var eventName = details.auxData["eventName"];
248 var targetName = details.auxData["targetName"]; 248 var targetName = details.auxData["targetName"];
249 this.sidebarPanes.eventListenerBreakpoints.highlightBreakpoint(event Name, targetName); 249 this.sidebarPanes.eventListenerBreakpoints.highlightBreakpoint(event Name, targetName);
250 var eventNameForUI = WebInspector.EventListenerBreakpointsSidebarPan e.eventNameForUI(eventName, details.auxData); 250 var eventNameForUI = WebInspector.EventListenerBreakpointsSidebarPan e.eventNameForUI(eventName, details.auxData);
251 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a \"%s\" Event Listener.", eventNameForUI)); 251 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a \"%s\" Event Listener.", eventNameForUI));
252 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.XHR ) { 252 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.XHR ) {
253 this.sidebarPanes.xhrBreakpoints.highlightBreakpoint(details.auxData ["breakpointURL"]); 253 this.sidebarPanes.xhrBreakpoints.highlightBreakpoint(details.auxData ["breakpointURL"]);
254 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a XMLHttpRequest.")); 254 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a XMLHttpRequest."));
255 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Exc eption) { 255 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Exc eption) {
256 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on exception: '%s'.", details.auxData["description"].split("\n", 1)[0])); 256 var description = details.auxData["description"] || "";
257 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on exception: '%s'.", description.split("\n", 1)[0]));
257 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Pro miseRejection) { 258 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Pro miseRejection) {
258 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on promise rejection: '%s'.", details.auxData["description"].split("\n", 1)[0])) ; 259 var description = details.auxData["description"] || "";
260 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on promise rejection: '%s'.", description.split("\n", 1)[0]));
259 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Ass ert) { 261 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Ass ert) {
260 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on assertion.")); 262 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on assertion."));
261 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.CSP Violation) { 263 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.CSP Violation) {
262 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a script blocked due to Content Security Policy directive: \"%s\".", details. auxData["directiveText"])); 264 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a script blocked due to Content Security Policy directive: \"%s\".", details. auxData["directiveText"]));
263 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Deb ugCommand) { 265 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Deb ugCommand) {
264 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a debugged function.")); 266 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a debugged function."));
265 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Asy ncOperation) { 267 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Asy ncOperation) {
266 if (Runtime.experiments.isEnabled("stepIntoAsync")) { 268 if (Runtime.experiments.isEnabled("stepIntoAsync")) {
267 var operationId = details.auxData["operationId"]; 269 var operationId = details.auxData["operationId"];
268 var operation = this.sidebarPanes.asyncOperationBreakpoints.oper ationById(details.target(), operationId); 270 var operation = this.sidebarPanes.asyncOperationBreakpoints.oper ationById(details.target(), operationId);
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 this._splitWidget.element.classList.toggle("sources-split-view-vertical" , vertically); 1144 this._splitWidget.element.classList.toggle("sources-split-view-vertical" , vertically);
1143 1145
1144 if (!vertically) 1146 if (!vertically)
1145 this._splitWidget.uninstallResizer(this._sourcesView.toolbarContaine rElement()); 1147 this._splitWidget.uninstallResizer(this._sourcesView.toolbarContaine rElement());
1146 else 1148 else
1147 this._splitWidget.installResizer(this._sourcesView.toolbarContainerE lement()); 1149 this._splitWidget.installResizer(this._sourcesView.toolbarContainerE lement());
1148 1150
1149 // Create vertical box with stack. 1151 // Create vertical box with stack.
1150 var vbox = new WebInspector.VBox(); 1152 var vbox = new WebInspector.VBox();
1151 vbox.element.appendChild(this._debugToolbarDrawer); 1153 vbox.element.appendChild(this._debugToolbarDrawer);
1152 vbox.element.appendChild(this._debugToolbar.element);
1153 vbox.setMinimumAndPreferredSizes(25, 25, WebInspector.SourcesPanel.minTo olbarWidth, 100); 1154 vbox.setMinimumAndPreferredSizes(25, 25, WebInspector.SourcesPanel.minTo olbarWidth, 100);
1154 var sidebarPaneStack = new WebInspector.SidebarPaneStack(); 1155 var sidebarPaneStack = new WebInspector.SidebarPaneStack();
1155 sidebarPaneStack.element.classList.add("flex-auto"); 1156 sidebarPaneStack.element.classList.add("flex-auto");
1156 sidebarPaneStack.show(vbox.element); 1157 sidebarPaneStack.show(vbox.element);
1158 vbox.element.appendChild(this._debugToolbar.element);
1157 1159
1158 if (!vertically) { 1160 if (!vertically) {
1159 // Populate the only stack. 1161 // Populate the only stack.
1160 for (var pane in this.sidebarPanes) 1162 for (var pane in this.sidebarPanes)
1161 sidebarPaneStack.addPane(this.sidebarPanes[pane]); 1163 sidebarPaneStack.addPane(this.sidebarPanes[pane]);
1162 this._extensionSidebarPanesContainer = sidebarPaneStack; 1164 this._extensionSidebarPanesContainer = sidebarPaneStack;
1163 this.sidebarPaneView = vbox; 1165 this.sidebarPaneView = vbox;
1164 1166
1165 this.sidebarPanes.scopechain.expand(); 1167 this.sidebarPanes.scopechain.expand();
1166 this.sidebarPanes.watchExpressions.expandIfNecessary(); 1168 this.sidebarPanes.watchExpressions.expandIfNecessary();
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 WebInspector.SourcesPanelFactory.prototype = { 1458 WebInspector.SourcesPanelFactory.prototype = {
1457 /** 1459 /**
1458 * @override 1460 * @override
1459 * @return {!WebInspector.Panel} 1461 * @return {!WebInspector.Panel}
1460 */ 1462 */
1461 createPanel: function() 1463 createPanel: function()
1462 { 1464 {
1463 return WebInspector.SourcesPanel.instance(); 1465 return WebInspector.SourcesPanel.instance();
1464 } 1466 }
1465 } 1467 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sidebarPane.css ('k') | Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698