DevTools: border and toolbar colors from Max's mocks.

DevTools: border and toolbar colors from Max's mocks.

BUG=498750, 499202
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197117

[pfeldman, 2015-06-12 14:15:45]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org, maxwalker@chromium.org

[pfeldman, 2015-06-12 14:15:46]

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sidebarPane.css (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sidebarPane.css:37: .sidebar-pane-hidden {
This was reviewed once, fell of the commit.

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sources/SourcesPanel.js (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sources/SourcesPanel.js:256: var description =
details.auxData["description"] || "";
came across these while reloading.

[dgozman, 2015-06-12 17:49:42]

Screenshot please.

[pfeldman, 2015-06-12 17:51:43]

The changes are really suble: http://grab.by/I28I

[pfeldman, 2015-06-12 18:52:20]

subtle

[dgozman, 2015-06-12 18:56:18]

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sources/SourcesPanel.js (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sources/SourcesPanel.js:1158:
vbox.element.appendChild(this._debugToolbar.element);
Toolbar at the bottom???

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui/tabbedPane.css (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/tabbedPane.css:214: height: 1px;
Is it enough? Probably makes it hard to tell which one is selected.

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui/toolbar.css (left):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/toolbar.css:97: transition: background-color 150ms
cubic-bezier(0, 0, 0.2, 1);
Transition was nice!

[pfeldman, 2015-06-12 19:35:29]

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sources/SourcesPanel.js (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sources/SourcesPanel.js:1158:
vbox.element.appendChild(this._debugToolbar.element);
On 2015/06/12 18:56:17, dgozman wrote:
> Toolbar at the bottom???

Yes, it is absolutely positioned.

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui/tabbedPane.css (right):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/tabbedPane.css:214: height: 1px;
On 2015/06/12 18:56:17, dgozman wrote:
> Is it enough? Probably makes it hard to tell which one is selected.

Lets give it a try. I am not a huge fan of it wither, but Max finds it more
elegant.

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui/toolbar.css (left):

https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/toolbar.css:97: transition: background-color 150ms
cubic-bezier(0, 0, 0.2, 1);
On 2015/06/12 18:56:17, dgozman wrote:
> Transition was nice!

I tend to agree with Max that it was too much for a toolbar button.

[dgozman, 2015-06-15 12:13:51]

- Active state on toolbar buttons is gone.
- Hover on applied filter button remove blue color.

rest lgtm

https://codereview.chromium.org/1179183002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/ui/toolbar.css (right):

https://codereview.chromium.org/1179183002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/ui/toolbar.css:267: -webkit-mask-position: -160px 1px;
That's weird. We should align glyphs. It may be better to have "top: -1px" here
instead.

[pfeldman, 2015-06-15 14:18:26]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-15 14:18:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1179183002/#ps80001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2015-06-15 14:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179183002/80001

[pfeldman, 2015-06-15 15:04:00]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2015-06-15 15:04:05]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-06-15 15:04:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179183002/80001

[commit-bot: I haz the power, 2015-06-15 15:08:34]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197117

[maxwalker, 2015-06-15 17:39:10]

lgtm