Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1179183002: DevTools: border and toolbar colors from Max's mocks. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman, maxwalker
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: border and toolbar colors from Max's mocks. BUG=498750, 499202 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197117

Patch Set 1 #

Total comments: 8

Patch Set 2 : back to 2px selection slider #

Patch Set 3 : increased minsize to reflect new toolbar sizes. #

Patch Set 4 : same with consistent editor status bar (26px + border, regular toolbar) #

Total comments: 1

Patch Set 5 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -68 lines) Patch
M Source/devtools/front_end/components/InspectorView.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/inspectorViewTabbedPane.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/sourcesPanel.css View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/sourcesView.css View 1 2 3 1 chunk +4 lines, -13 lines 0 comments Download
M Source/devtools/front_end/ui/splitWidget.css View 1 2 3 3 chunks +7 lines, -24 lines 0 comments Download
M Source/devtools/front_end/ui/tabbedPane.css View 1 3 chunks +7 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/toolbar.css View 1 2 3 4 7 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
pfeldman
https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sidebarPane.css File Source/devtools/front_end/sidebarPane.css (right): https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sidebarPane.css#newcode37 Source/devtools/front_end/sidebarPane.css:37: .sidebar-pane-hidden { This was reviewed once, fell of the ...
4 years, 10 months ago (2015-06-12 14:15:46 UTC) #2
dgozman
Screenshot please.
4 years, 10 months ago (2015-06-12 17:49:42 UTC) #3
pfeldman
The changes are really suble: http://grab.by/I28I
4 years, 10 months ago (2015-06-12 17:51:43 UTC) #4
pfeldman
subtle
4 years, 10 months ago (2015-06-12 18:52:20 UTC) #5
dgozman
https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode1158 Source/devtools/front_end/sources/SourcesPanel.js:1158: vbox.element.appendChild(this._debugToolbar.element); Toolbar at the bottom??? https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/ui/tabbedPane.css File Source/devtools/front_end/ui/tabbedPane.css (right): ...
4 years, 10 months ago (2015-06-12 18:56:18 UTC) #6
pfeldman
https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/1179183002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode1158 Source/devtools/front_end/sources/SourcesPanel.js:1158: vbox.element.appendChild(this._debugToolbar.element); On 2015/06/12 18:56:17, dgozman wrote: > Toolbar at ...
4 years, 10 months ago (2015-06-12 19:35:29 UTC) #7
dgozman
- Active state on toolbar buttons is gone. - Hover on applied filter button remove ...
4 years, 10 months ago (2015-06-15 12:13:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179183002/80001
4 years, 10 months ago (2015-06-15 14:18:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179183002/80001
4 years, 10 months ago (2015-06-15 15:04:17 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197117
4 years, 10 months ago (2015-06-15 15:08:34 UTC) #15
maxwalker
4 years, 10 months ago (2015-06-15 17:39:10 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698