Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1179163002: Migrate callers of message_loop_proxy() to task_runner() (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
armansito, jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, scheib+watch_chromium.org, ben+mojo_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, pvalenzuela+watch_chromium.org, stevenjb+watch_chromium.org, chromoting-reviews_chromium.org, abarth-chromium, hguihot+watch_chromium.org, yfriedman+watch_chromium.org, kalyank, jbudorick+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, dcheng, oshima+watch_chromium.org, klundberg+watch_chromium.org, maniscalco+watch_chromium.org, hclam+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, darin (slow to review), wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate callers of message_loop_proxy() to task_runner() Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Committed: https://crrev.com/8a033aaf2d76655ce5686cd80b36a759582dcd6d Cr-Commit-Position: refs/heads/master@{#334840}

Patch Set 1 #

Patch Set 2 : Formatting. #

Patch Set 3 : Split out largest components. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/offline_pages/offline_page_metadata_store_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/bus.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/bus_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M dbus/object_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/property_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M dbus/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/task_runners.h View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/rlz_lib_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_downloader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M sync/test/fake_server/fake_server_network_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/get_session_name_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/device_forwarder_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/device_listener.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/forwarders_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/android/forwarder2/host_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
Sami
5 years, 6 months ago (2015-06-12 14:05:56 UTC) #2
jam
this doesn't need a top level owner to review. any way you can find someone ...
5 years, 6 months ago (2015-06-12 16:37:51 UTC) #3
Sami
On 2015/06/12 16:37:51, jam wrote: > this doesn't need a top level owner to review. ...
5 years, 6 months ago (2015-06-12 17:06:07 UTC) #4
Sami
(btw, I've now split out the biggest components -- does it look more reasonable now?)
5 years, 6 months ago (2015-06-12 17:19:18 UTC) #5
jam
lgtm
5 years, 6 months ago (2015-06-15 16:36:34 UTC) #6
Sami
Thanks John! armansito@, could you check device/bluetooth/bluetooth_socket_thread.cc please?
5 years, 6 months ago (2015-06-15 20:05:38 UTC) #8
Sami
I'll TBR device/bluetooth/bluetooth_socket_thread.cc since the change there is trivial and matches all the other changes ...
5 years, 6 months ago (2015-06-17 01:32:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179163002/60001
5 years, 6 months ago (2015-06-17 01:34:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/100090)
5 years, 6 months ago (2015-06-17 03:21:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179163002/60001
5 years, 6 months ago (2015-06-17 03:40:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/100131)
5 years, 6 months ago (2015-06-17 05:24:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179163002/60001
5 years, 6 months ago (2015-06-17 15:11:25 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-17 15:46:13 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 15:47:20 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8a033aaf2d76655ce5686cd80b36a759582dcd6d
Cr-Commit-Position: refs/heads/master@{#334840}

Powered by Google App Engine
This is Rietveld 408576698