SP: antialias images regardless of CTM.

SP: antialias images regardless of CTM.

BUG=382491
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197355

[chrishtr, 2015-06-14 05:37:38]

chrishtr@chromium.org changed reviewers:
+ fmalita@chromium.org, fs@opera.com, pdr@chromium.org

[chrishtr, 2015-06-14 05:37:39]

See the image diffs on the various platforms. Are they ok?

[fs, 2015-06-15 10:36:01]

On 2015/06/14 05:37:39, chrishtr wrote:
> See the image diffs on the various platforms. Are they ok?

One that stood out to me was:

https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/58...

It's not directly obvious if the new result is better or not, but given the
change it seems there's now an (indiscernable) seam between the images. If
that's the only one though, then maybe it's not too bad...

[f(malita), 2015-06-15 13:43:14]

On 2015/06/15 at 10:36:01, fs wrote:
> On 2015/06/14 05:37:39, chrishtr wrote:
> > See the image diffs on the various platforms. Are they ok?
> 
> One that stood out to me was:
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/58...
> 
> It's not directly obvious if the new result is better or not, but given the
change it seems there's now an (indiscernable) seam between the images. If
that's the only one though, then maybe it's not too bad...

Here's the one that worries me:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

It shows a little red bg bleed on the edge.  I would be fine with that, but it
seems to be a test specifically targeted at some DSF image vs. bg bleed.  I'll
take a close look at that bug and verify that the change doesn't regress it.

[chrishtr, 2015-06-15 15:30:40]

On 2015/06/15 at 13:43:14, fmalita wrote:
> On 2015/06/15 at 10:36:01, fs wrote:
> > On 2015/06/14 05:37:39, chrishtr wrote:
> > > See the image diffs on the various platforms. Are they ok?
> > 
> > One that stood out to me was:
> > 
> >
https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/58...
> > 
> > It's not directly obvious if the new result is better or not, but given the
change it seems there's now an (indiscernable) seam between the images. If
that's the only one though, then maybe it's not too bad...
> 
> Here's the one that worries me:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
> 
> It shows a little red bg bleed on the edge.  I would be fine with that, but it
seems to be a test specifically targeted at some DSF image vs. bg bleed.  I'll
take a close look at that bug and verify that the change doesn't regress it.

Ok thanks. Will wait for the results.

[f(malita), 2015-06-15 16:17:49]

On 2015/06/15 at 15:30:40, chrishtr wrote:
> On 2015/06/15 at 13:43:14, fmalita wrote:
> > Here's the one that worries me:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
> > 
> > It shows a little red bg bleed on the edge.  I would be fine with that, but
it seems to be a test specifically targeted at some DSF image vs. bg bleed. 
I'll take a close look at that bug and verify that the change doesn't regress
it.
> 
> Ok thanks. Will wait for the results.

The test was introduced in https://codereview.chromium.org/711163002, so you may
also be familiar with what's going on.

I ran it at 3.5 DSF and I don't see the initial issue (1 row of red pixels at
the top).  So I'm fine with trying this out, but it's possible that the AA bleed
on the right/bottom edges  is going to cause similar issues at fractional DSF.

https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
File Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
Source/platform/graphics/GraphicsContext.h:283: bool shouldAntialiasImages() {
return shouldAntialias(); }
We might as well drop shouldAntialiasImages() at this point.

[chrishtr, 2015-06-16 22:00:59]

On 2015/06/15 at 16:17:49, fmalita wrote:
> On 2015/06/15 at 15:30:40, chrishtr wrote:
> > On 2015/06/15 at 13:43:14, fmalita wrote:
> > > Here's the one that worries me:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
> > > 
> > > It shows a little red bg bleed on the edge.  I would be fine with that,
but it seems to be a test specifically targeted at some DSF image vs. bg bleed. 
I'll take a close look at that bug and verify that the change doesn't regress
it.
> > 
> > Ok thanks. Will wait for the results.
> 
> The test was introduced in https://codereview.chromium.org/711163002, so you
may also be familiar with what's going on.
> 
> I ran it at 3.5 DSF and I don't see the initial issue (1 row of red pixels at
the top).  So I'm fine with trying this out, but it's possible that the AA bleed
on the right/bottom edges  is going to cause similar issues at fractional DSF.
> 
>
https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
> File Source/platform/graphics/GraphicsContext.h (right):
> 
>
https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
> Source/platform/graphics/GraphicsContext.h:283: bool shouldAntialiasImages() {
return shouldAntialias(); }
> We might as well drop shouldAntialiasImages() at this point.

Done.

[f(malita), 2015-06-16 22:33:34]

On 2015/06/16 at 22:00:59, chrishtr wrote:
> On 2015/06/15 at 16:17:49, fmalita wrote:
> > On 2015/06/15 at 15:30:40, chrishtr wrote:
> > > On 2015/06/15 at 13:43:14, fmalita wrote:
> > > > Here's the one that worries me:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
> > > > 
> > > > It shows a little red bg bleed on the edge.  I would be fine with that,
but it seems to be a test specifically targeted at some DSF image vs. bg bleed. 
I'll take a close look at that bug and verify that the change doesn't regress
it.
> > > 
> > > Ok thanks. Will wait for the results.
> > 
> > The test was introduced in https://codereview.chromium.org/711163002, so you
may also be familiar with what's going on.
> > 
> > I ran it at 3.5 DSF and I don't see the initial issue (1 row of red pixels
at the top).  So I'm fine with trying this out, but it's possible that the AA
bleed on the right/bottom edges  is going to cause similar issues at fractional
DSF.
> > 
> >
https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
> > File Source/platform/graphics/GraphicsContext.h (right):
> > 
> >
https://codereview.chromium.org/1179143003/diff/1/Source/platform/graphics/Gr...
> > Source/platform/graphics/GraphicsContext.h:283: bool shouldAntialiasImages()
{ return shouldAntialias(); }
> > We might as well drop shouldAntialiasImages() at this point.
> 
> Done.

LGTM </insanity wolf>

[chrishtr, 2015-06-17 18:29:34]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-17 18:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1179143003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-06-17 18:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179143003/100001

[commit-bot: I haz the power, 2015-06-17 18:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 18:46:40]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[chrishtr, 2015-06-17 19:51:19]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-17 19:52:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179143003/100001

[chrishtr, 2015-06-18 01:56:41]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-18 01:56:41]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1179143003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-06-18 01:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179143003/140001

[commit-bot: I haz the power, 2015-06-18 03:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 03:56:19]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59399)

[chrishtr, 2015-06-18 04:25:13]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-18 04:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179143003/140001

[commit-bot: I haz the power, 2015-06-18 05:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 05:50:53]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59416)

[chrishtr, 2015-06-18 14:23:19]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-18 14:23:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179143003/140001

[commit-bot: I haz the power, 2015-06-18 14:59:49]

Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197355