Issue 1179143002: Oilpan: eagerly finalize MIDIAccess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179143002: Oilpan: eagerly finalize MIDIAccess. (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: eagerly finalize MIDIAccess. MIDIAccess' MIDIAccessor is registered as a callable client of the embedder's WebMIDIAccessor. It is unsafe to access that client interface during lazy sweeping, as it might access heap objects that have been finalized. Consequently, mark MIDIAccess as eagerly finalized, making it release its MIDIAccessor before the mutator is allowed heap access after a GC. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197038

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	Source/modules/webmidi/MIDIAccess.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179143002/1

5 years, 6 months ago (2015-06-12 14:33:00 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-12 14:37:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197038

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages