Refactoring: Remove the first parameter |result| from StyledMarkupAccumulator::appendStartMarkup

Refactoring: Remove the first parameter |result| from StyledMarkupAccumulator::appendStartMarkup

StyledMarkupAccumulator::appendStartMarkup's first parameter |result| is
|m_result| in most cases. This CL removes this to improve code readability.

The case when the parameter is NOT |m_result| is at
StyledMarkupSerializer::wrapWithNode. In this case, |node| must be a
Document or a DocumentFragment. This CL extracts the code in
MarkupFormatter for this case at the caller.

BUG=499681
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197026

[hajimehoshi, 2015-06-12 07:42:36]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-12 07:42:47]

PTAL

[yosin_UTC9, 2015-06-12 07:58:04]

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupAccumulator.cpp:83:
appendElementWithInlineStyle(m_result, element, style);
Since |appendElement()| checks |element.isHTMLElement() && shouldAnnotate()) ||
shouldApplyWrappingStyle(element)|, is it OK to call
|appendElementWithInlineStyle()| without checking the condition?

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupAccumulator.h (right):

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupAccumulator.h:74: void
appendText(StringBuilder&, Text&);
Since, this CL removes |appendText()| implementation, we don't need to have a
declaration.

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupSerializer.cpp:318: if (!node.isElementNode()) {
nit: We don't need to have curry brace.

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupSerializer.cpp:321: 
We don't need to have an extra blank line.

[hajimehoshi, 2015-06-12 08:14:14]

Thanks! PTAL

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupSerializer.cpp:318: if (!node.isElementNode()) {
On 2015/06/12 07:58:04, Yosi_UTC9 wrote:
> nit: We don't need to have curry brace.

Done.

https://codereview.chromium.org/1179133002/diff/40001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupSerializer.cpp:321: 
On 2015/06/12 07:58:04, Yosi_UTC9 wrote:
> We don't need to have an extra blank line.

Done.

[yosin_UTC9, 2015-06-12 08:37:51]

lgtm

[yosin_UTC9, 2015-06-12 08:37:54]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-12 08:38:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179133002/60001

[commit-bot: I haz the power, 2015-06-12 09:58:02]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197026