Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 11791051: Support immediate and memory operands for PushArgumentInstr in optimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: really handle constant operands Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 16802)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -2253,28 +2253,6 @@
}
-LocationSummary* PushArgumentInstr::MakeLocationSummary() const {
- const intptr_t kNumInputs = 1;
- const intptr_t kNumTemps= 0;
- LocationSummary* locs =
- new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
- // TODO(fschneider): Use Any() once it is supported by all code generators.
- locs->set_in(0, Location::RequiresRegister());
- return locs;
-}
-
-
-void PushArgumentInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- // In SSA mode, we need an explicit push. Nothing to do in non-SSA mode
- // where PushArgument is handled by BindInstr::EmitNativeCode.
- // TODO(fschneider): Avoid special-casing for SSA mode here.
- if (compiler->is_optimizing()) {
- ASSERT(locs()->in(0).IsRegister());
- __ PushRegister(locs()->in(0).reg());
- }
-}
-
-
Environment* Environment::From(const GrowableArray<Definition*>& definitions,
intptr_t fixed_parameter_count,
const Function& function) {
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698