Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 11791036: Enforce consistent include style for ICU headers. (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Enforce consistent include style for ICU headers. Instead of "unicode/...", "third_party/icu/public/..." should always be used in Chromium code. This matches the established style. BUG=165264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175929

Patch Set 1 #

Patch Set 2 : fix other file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M DEPS View 1 2 chunks +1 line, -3 lines 0 comments Download
M base/i18n/time_formatting_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-07 23:16:57 UTC) #1
brettw
7 years, 11 months ago (2013-01-09 20:17:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698