Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1179103002: Forbid entering recalcStyle or attach from inside detach. (Closed)

Created:
5 years, 6 months ago by esprehn
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Forbid entering recalcStyle or attach from inside detach. Lets assert that once we're in detach we don't try to go back into style resolving or attaching mode. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179103002/1
5 years, 6 months ago (2015-06-12 02:13:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 04:45:35 UTC) #4
esprehn
5 years, 6 months ago (2015-06-12 04:58:01 UTC) #6
Timothy Loh
On 2015/06/12 04:58:01, esprehn wrote: lgtm
5 years, 6 months ago (2015-06-12 05:03:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179103002/1
5 years, 6 months ago (2015-06-12 05:10:03 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 05:13:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196999

Powered by Google App Engine
This is Rietveld 408576698