Use HighDPI asset on about:flags

Use HighDPI asset on about:flags

BUG=168360
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175614

[Nico, 2013-01-07 18:58:52]

This is identical to what plugins.css does.

[Dan Beam, 2013-01-07 19:39:21]

https://codereview.chromium.org/11791026/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags.css (right):

https://codereview.chromium.org/11791026/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.css:32:
url('../../app/theme/default_100_percent/flags_section.png') 1x,
if possible I'd like to use grit to autogenerate this for us like this -
https://codereview.chromium.org/11774004 - is there a functional difference?

[Dan Beam, 2013-01-07 19:39:59]

(btw, if other places do this I'd prefer to make them auto-generate as well)

[Nico, 2013-01-08 21:34:26]

Thanks for the quick review, sorry for dropping the ball on this.

On Mon, Jan 7, 2013 at 11:39 AM,  <dbeam@chromium.org> wrote:
>
>
https://codereview.chromium.org/11791026/diff/1/chrome/browser/resources/flag...
> File chrome/browser/resources/flags.css (right):
>
>
https://codereview.chromium.org/11791026/diff/1/chrome/browser/resources/flag...
> chrome/browser/resources/flags.css:32:
> url('../../app/theme/default_100_percent/flags_section.png') 1x,
> if possible I'd like to use grit to autogenerate this for us like this -
> https://codereview.chromium.org/11774004 - is there a functional
> difference?

I think the main difference is that the image data doesn't get inlined
but is fetched via separate requests.

> (btw, if other places do this I'd prefer to make them auto-generate as well)

That's a chunk of work:

$ ack webkit-image-set chrome/browser/resources | wc -l
     188


This CL as is is consistent with plugins.css, which has very similar
structure as flags.css. I'd like to keep them in sync.

[Dan Beam, 2013-01-08 22:17:38]

I don't particularly think this is the right way, as I'd far prefer grit
generate this itself as:

a) the format of each style declaration could change
b) the number of x's could change (i.e. a 3x)
c) chrome://theme/ would allow this resource to be cached more efficiently and
the binary to me smaller, to my knowledge

That said, lgtm as this adds useful functionality.

[commit-bot: I haz the power, 2013-01-08 22:46:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11791026/1