Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: runtime/vm/compiler.cc

Issue 11791024: Do ComputeUseLists after ApplyClassIds. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/code_generator.h" 10 #include "vm/code_generator.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 199
200 // Verify that the use lists are still valid. 200 // Verify that the use lists are still valid.
201 DEBUG_ASSERT(flow_graph->ValidateUseLists()); 201 DEBUG_ASSERT(flow_graph->ValidateUseLists());
202 202
203 // Propagate sminess from CheckSmi to phis. 203 // Propagate sminess from CheckSmi to phis.
204 optimizer.PropagateSminess(); 204 optimizer.PropagateSminess();
205 205
206 // Use propagated class-ids to optimize further. 206 // Use propagated class-ids to optimize further.
207 optimizer.ApplyClassIds(); 207 optimizer.ApplyClassIds();
208 208
209 // Recompute use lists after applying class ids.
210 flow_graph->ComputeUseLists();
211
209 // Do optimizations that depend on the propagated type information. 212 // Do optimizations that depend on the propagated type information.
210 // TODO(srdjan): Should this be called CanonicalizeComputations? 213 // TODO(srdjan): Should this be called CanonicalizeComputations?
211 optimizer.OptimizeComputations(); 214 optimizer.OptimizeComputations();
212 215
213 // Unbox doubles. 216 // Unbox doubles.
214 flow_graph->ComputeUseLists(); 217 flow_graph->ComputeUseLists();
215 optimizer.SelectRepresentations(); 218 optimizer.SelectRepresentations();
216 219
217 if (FLAG_constant_propagation || 220 if (FLAG_constant_propagation ||
218 FLAG_common_subexpression_elimination) { 221 FLAG_common_subexpression_elimination) {
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 Object::Handle(isolate->object_store()->sticky_error()); 639 Object::Handle(isolate->object_store()->sticky_error());
637 isolate->object_store()->clear_sticky_error(); 640 isolate->object_store()->clear_sticky_error();
638 isolate->set_long_jump_base(base); 641 isolate->set_long_jump_base(base);
639 return result.raw(); 642 return result.raw();
640 } 643 }
641 UNREACHABLE(); 644 UNREACHABLE();
642 return Object::null(); 645 return Object::null();
643 } 646 }
644 647
645 } // namespace dart 648 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698