Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1179083006: ScopedPtrMap: Added Compare template parameter. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScopedPtrMap: Added Compare template parameter. Allows clients to specify a custom comparison function (as in std::map). Also added |mapped_type| and |key_compare| typedefs in ScopedPtrMap, for compatibility with std::map. BUG=478594 Committed: https://crrev.com/24486e2517f5bbb84bc79aa908d81ec6eb34d676 Cr-Commit-Position: refs/heads/master@{#334549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M base/containers/scoped_ptr_map.h View 3 chunks +5 lines, -2 lines 0 comments Download
M base/containers/scoped_ptr_map_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Would you believe that while I was landing ScopedPtrMap, one of the prospective clients (GCMClientImpl) ...
5 years, 6 months ago (2015-06-15 04:54:25 UTC) #2
danakj
LGTM
5 years, 6 months ago (2015-06-15 20:09:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179083006/1
5 years, 6 months ago (2015-06-16 01:23:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 03:30:17 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 03:31:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24486e2517f5bbb84bc79aa908d81ec6eb34d676
Cr-Commit-Position: refs/heads/master@{#334549}

Powered by Google App Engine
This is Rietveld 408576698