Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1179083002: Revert of Mark ui_base_unittests target to be used on Swarming. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
tfarina, M-A Ruel
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark ui_base_unittests target to be used on Swarming. (patchset #2 id:20001 of https://codereview.chromium.org/1063603002/) Reason for revert: Turns "isolate tests" red on some bots, reverting while maruel investigates: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/765/steps/isolate%20tests/logs/stdio Original issue's description: > Mark ui_base_unittests target to be used on Swarming. > > Patch generated with the following command line: > > $ ./testing/buildbot/manage.py --convert ui_base_unittests > > BUG=98637 > TEST=trybots? > R=maruel@chromium.org > > Committed: https://crrev.com/79e2c2139c83ccc50de4a73288eac94ab13b94f0 > Cr-Commit-Position: refs/heads/master@{#333991} TBR=maruel@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/6b2a998c601aec800ad1f0f30b2369fd49a9580b Cr-Commit-Position: refs/heads/master@{#334051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 13 chunks +0 lines, -39 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 4 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Created Revert of Mark ui_base_unittests target to be used on Swarming.
5 years, 6 months ago (2015-06-11 22:07:38 UTC) #1
M-A Ruel
On 2015/06/11 22:07:38, Nico wrote: > Created Revert of Mark ui_base_unittests target to be used ...
5 years, 6 months ago (2015-06-11 22:08:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179083002/1
5 years, 6 months ago (2015-06-11 22:08:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 22:11:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b2a998c601aec800ad1f0f30b2369fd49a9580b Cr-Commit-Position: refs/heads/master@{#334051}
5 years, 6 months ago (2015-06-11 22:13:18 UTC) #5
Nico
5 years, 6 months ago (2015-06-11 22:14:28 UTC) #6
Message was sent while issue was closed.
Oh sorry, I thought that's what you meant with unblocking :-/

I looked around a bit, I think the problem might be that build/all.gyp doesn't
list ui_base_unittests_run in chromium_swarm_tests. The clang bots build "all"
targets, which means the targets referenced directly by build/all.gyp get built.
So that's probably why it doesn't isolate that specific test.

Powered by Google App Engine
This is Rietveld 408576698