Issue 117903005: compile error fix for VS2013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117903005: compile error fix for VS2013 (Closed)

Created:
6 years, 11 months ago by shinyak

Modified:
6 years, 11 months ago

Reviewers:
Nico, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

compile error fix for VS2013 std::max and std::min requires algorithm header. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243146

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/test/base/browser_tests_main.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

shinyak

Hi, I would like to fix compile error on VS2013. Could you review it?

6 years, 11 months ago (2014-01-06 09:20:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shinyak@chromium.org/117903005/1

6 years, 11 months ago (2014-01-06 17:18:03 UTC) #4

Message was sent while issue was closed.

Change committed as 243146