Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1179003002: Rebuild property_tree after LayerImpl::SetTransform() is called in tests (Closed)

Created:
5 years, 6 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 6 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebuild property_tree after LayerImpl::SetTransform() is called in tests This fixes test LayerTreeHostCommonTest.MaximumAnimationScaleFactor If LayerImpl::SetTransform() is called, we need to rebuild/update the property_tree. In practice, LayerImpl::SetTransform() is only called through LayerImpl::OnTransformAnimated(), where we already do property tree update. In test LayerImpl::SetTranform() can be triggered by itself, in this case, lets just force a property rebuild. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/843080ca2357f8441b77e3dd8a5aa32184f7b47a Cr-Commit-Position: refs/heads/master@{#334050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yufeng Shen (Slow to review)
5 years, 6 months ago (2015-06-11 18:51:34 UTC) #2
enne (OOO)
lgtm if you fix all the "tranform" typos in the CL title and description I ...
5 years, 6 months ago (2015-06-11 20:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179003002/1
5 years, 6 months ago (2015-06-11 21:22:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 22:11:08 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 22:11:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/843080ca2357f8441b77e3dd8a5aa32184f7b47a
Cr-Commit-Position: refs/heads/master@{#334050}

Powered by Google App Engine
This is Rietveld 408576698