Always make an attempt to fill in the suggested filename.

Always make an attempt to fill in the suggested filename.

BUG=35811
TEST=drag the [Next] image from http://www-sul.stanford.edu/tools/tutorials/html2.0/img.html and drop it on the desktop; the resulting file should be named "nextbtn.gif", not "tables.gif"


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175502

[Avi (use Gerrit), 2013-01-07 21:49:21]

Darin, you put in the TODO here, so while this isn't the ideal solution, it's
better than nothing. Is there a reason why we wouldn't want to do this?

[darin (slow to review), 2013-01-07 23:05:03]

Core change looks good to me.

https://codereview.chromium.org/11790003/diff/1/webkit/glue/weburlloader_impl.cc
File webkit/glue/weburlloader_impl.cc (right):

https://codereview.chromium.org/11790003/diff/1/webkit/glue/weburlloader_impl...
webkit/glue/weburlloader_impl.cc:265: while
(headers->EnumerateHeaderLines(&iter, &name, &disposition_filename)) {
nit: This is an awkward use of the variable named disposition_filename.  |value|
was generic, so it worked in both cases.  Here, we are enumerating response
headers, and you are assigning the value of a header to the variable named
disposition_filename, which is confusing.  I'm guessing you just did a
search-n-replace of |value| to |disposition_filename|.

[Avi (use Gerrit), 2013-01-07 23:08:25]

https://codereview.chromium.org/11790003/diff/1/webkit/glue/weburlloader_impl.cc
File webkit/glue/weburlloader_impl.cc (right):

https://codereview.chromium.org/11790003/diff/1/webkit/glue/weburlloader_impl...
webkit/glue/weburlloader_impl.cc:265: while
(headers->EnumerateHeaderLines(&iter, &name, &disposition_filename)) {
I actually didn't see this second use of |value| :O. Will switch back.

[darin (slow to review), 2013-01-07 23:10:08]

OK, LGTM w/ the variable named back to |value|.

[commit-bot: I haz the power, 2013-01-08 03:07:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11790003/7001

[commit-bot: I haz the power, 2013-01-08 08:44:03]

Change committed as 175502