Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2468)

Unified Diff: cc/output/swap_promise.h

Issue 1178963003: Trace main thread commit in flow events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make OnCommitForSwapPromises non pure so that not all the derived classes need to implement it. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/latency_info_swap_promise.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/swap_promise.h
diff --git a/cc/output/swap_promise.h b/cc/output/swap_promise.h
index 45deee834018bdca7b1f7e2d104ab725ea54bee3..1c4afcbfd5a3ac3533470a1cfb348452c052a2a3 100644
--- a/cc/output/swap_promise.h
+++ b/cc/output/swap_promise.h
@@ -39,6 +39,8 @@ namespace cc {
// assume that Did*() methods are called at a particular thread. It is better
// to let the subclass carry thread-safe member data and operate on that
// member data in Did*().
+//
+// For each SwapPromise, OnCommitForSwapPromises traces its original LatencyInfo
Yufeng Shen (Slow to review) 2015/06/16 17:32:18 SwapPromise is generic, so you should only mention
class CC_EXPORT SwapPromise {
public:
enum DidNotSwapReason {
@@ -54,6 +56,7 @@ class CC_EXPORT SwapPromise {
virtual void DidActivate() = 0;
virtual void DidSwap(CompositorFrameMetadata* metadata) = 0;
virtual void DidNotSwap(DidNotSwapReason reason) = 0;
+ virtual void OnCommitForSwapPromises() {}
Yufeng Shen (Slow to review) 2015/06/16 17:32:18 ah, I actually meant the naming to be LayerTreeHos
// A non-zero trace id identifies a trace flow object that is embedded in the
// swap promise. This can be used for registering additional flow steps to
« no previous file with comments | « cc/output/latency_info_swap_promise.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698