cc/output/swap_promise.h - Issue 1178963003: Trace main thread commit in flow events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/swap_promise.h

Issue 1178963003: Trace main thread commit in flow events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make OnCommit virtual and only LatencyInfoSwapPromise can call it to trace flow events. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/swap_promise.h

diff --git a/cc/output/swap_promise.h b/cc/output/swap_promise.h

index 45deee834018bdca7b1f7e2d104ab725ea54bee3..636de4d529152699b224623b388c41cb81c0185e 100644

--- a/cc/output/swap_promise.h

+++ b/cc/output/swap_promise.h

@@ -54,6 +54,7 @@ class CC_EXPORT SwapPromise {

virtual void DidActivate() = 0;

virtual void DidSwap(CompositorFrameMetadata* metadata) = 0;

virtual void DidNotSwap(DidNotSwapReason reason) = 0;

+ virtual void OnCommit() = 0;

Yufeng Shen (Slow to review) 2015/06/16 15:11:05 maybe giving it an empty implementation (non-virtu

// A non-zero trace id identifies a trace flow object that is embedded in the

// swap promise. This can be used for registering additional flow steps to