Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1178943009: Remove FT_HAS_COLOR definition. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove FT_HAS_COLOR definition. The intent was to define FT_HAS_COLOR when building with a pre 2.5.1 version of FreeType for forward compatibility. However, the definition here is wrong and also never used. Committed: https://skia.googlesource.com/skia/+/1e23736f59f64b88b595cec488352bcc0b3b8406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178943009/1
5 years, 6 months ago (2015-06-18 17:41:42 UTC) #2
bungeman-skia
Remove the dead code.
5 years, 6 months ago (2015-06-18 17:41:54 UTC) #4
djsollen
lgtm
5 years, 6 months ago (2015-06-18 17:43:27 UTC) #5
mtklein
lgtm. What's wrong with that definition?
5 years, 6 months ago (2015-06-18 17:44:20 UTC) #6
bungeman-skia
On 2015/06/18 17:44:20, mtklein wrote: > lgtm. What's wrong with that definition? It's always false ...
5 years, 6 months ago (2015-06-18 17:46:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-18 17:47:10 UTC) #9
mtklein
On 2015/06/18 17:47:10, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-18 17:47:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178943009/1
5 years, 6 months ago (2015-06-18 17:47:34 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 17:48:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e23736f59f64b88b595cec488352bcc0b3b8406

Powered by Google App Engine
This is Rietveld 408576698