Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dm_flags.py

Issue 1178943006: Stop running SKPs in DM on the bots. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: update expectation Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index ea657f8e6c43fda33f061478bc3602249f53646e..524e1b6212327ba5e5b15626eac6f2088851703e 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -68,6 +68,14 @@ def get_args(bot):
args.append('--config')
args.extend(configs)
+ # Run tests and gms everywhere,
+ # and image decoding tests everywhere except GPU bots.
+ # TODO: remove skp from default --src list?
+ if 'GPU' in bot:
+ args.extend('--src tests gm'.split(' '))
+ else:
+ args.extend('--src tests gm image'.split(' '))
+
if 'GalaxyS' in bot:
args.extend(('--threads', '0'))
@@ -117,13 +125,6 @@ def get_args(bot):
blacklist.extend('msaa16 gm _ colorwheelnative'.split(' '))
blacklist.extend('pdf gm _ fontmgr_iter_factory'.split(' '))
- # Drawing SKPs or images into GPU canvases is a New Thing.
- # We are running out of RAM on some Android bots, so we are restricting
- # all GPU Android bots to only run tests and GMs.
- if ('Android' in bot and
- 'GPU' in bot):
- args.extend('--src tests gm'.split(' '))
-
if 'Valgrind' in bot:
# PDF + .webp -> jumps depending on uninitialized memory. skia:3505
blacklist.extend('pdf _ _ .webp'.split(' '))
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698