DescriptionFix regression on positioned movement layout on a line from r195813
In https://codereview.chromium.org/1128713004 I inadvertently removed the layout
layoutPositionedObjects() was setting on objects that had a static inline position
and were inline objects made into blocks by virtue of being positioned.
I did this by wrong-headedly altering the isOriginalDisplayInlineType() to
isDisplayInlineType() when refactoring. This mistake was motivated by misunderstanding
the root of failures I saw locally when using isOriginalDisplayInlineType() in
my refactored code. This CL is what I should have done the first time: prior to
r195813 we always set a layout on positioned objects with a static block position
regardless of whether they were part of an inline or block flow. I incorrectly
changed that to only happen in inline flows when the object was itself block flow.
Restore the needed layouts so that our only difference versus the state of affairs
prior to r195813 is we don't set unnecessary layouts on block flow elements in
block flow layout.
BUG=498290
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196977
Patch Set 1 #Patch Set 2 : Updated #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||