Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1178853002: [heap] Unify the immortal immovable root detection mechanism. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unify the immortal immovable root detection mechanism. Uniformly use the Heap::GetRootListIndex() and Heap::RootIsImmortalImmovable() methods to detect immortal immovable roots in the optimizing compilers. R=jarin@chromium.org Committed: https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 Cr-Commit-Position: refs/heads/master@{#28933}

Patch Set 1 #

Patch Set 2 : Better naming. #

Patch Set 3 : Use the right predicate during code generation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -91 lines) Patch
M src/compiler/code-generator.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/heap/heap.h View 4 chunks +5 lines, -58 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +71 lines, -16 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +3 lines, -14 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/unique.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-11 08:18:01 UTC) #1
Benedikt Meurer
Hey Jaro, This is cleanup for the immortal immovable root stuff. The adhoc macro solution ...
5 years, 6 months ago (2015-06-11 08:24:17 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-11 09:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178853002/20001
5 years, 6 months ago (2015-06-11 09:17:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178853002/40001
5 years, 6 months ago (2015-06-11 09:47:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 10:12:38 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 Cr-Commit-Position: refs/heads/master@{#28933}
5 years, 6 months ago (2015-06-11 10:12:47 UTC) #11
Michael Achenbach
5 years, 6 months ago (2015-06-11 10:49:09 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1178083003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] tsan failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240.

Powered by Google App Engine
This is Rietveld 408576698