Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: tools/telemetry/support/html_output/results-template.html

Issue 1178843003: Use benchmark_name (date-time) instead of revision number for telemetry html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/TELEMETRY_DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/support/html_output/results-template.html
diff --git a/tools/telemetry/support/html_output/results-template.html b/tools/telemetry/support/html_output/results-template.html
index f1c13b79e71ed68e30c450fb69ae59f17893cc26..7d987b543645ebe6ff83fd9b8572f7fbe6dad461 100644
--- a/tools/telemetry/support/html_output/results-template.html
+++ b/tools/telemetry/support/html_output/results-template.html
@@ -343,25 +343,17 @@ function TestResult(metric, values, associatedRun) {
function TestRun(entry) {
this.id = function() { return entry['buildTime'].replace(/[:.-]/g,''); }
- this.revision = function () { return entry['revision']; }
this.label = function () {
if (labelKey in localStorage)
return localStorage[labelKey];
- if (entry['label'])
- return entry['label'];
- return 'r' + this.revision();
+ return entry['label'];
}
this.setLabel = function(label) { localStorage[labelKey] = label; }
this.isHidden = function() { return localStorage[hiddenKey]; }
this.hide = function() { localStorage[hiddenKey] = true; }
this.show = function() { localStorage.removeItem(hiddenKey); }
this.description = function() {
- var label = this.label();
- if (label != 'r' + this.revision())
- label = ' ' + label;
- else
- label = '';
- return new Date(entry['buildTime']).toLocaleString() + '\n' + entry['platform'] + ' r' + entry['revision'] + label;
+ return new Date(entry['buildTime']).toLocaleString() + '\n' + entry['platform'] + ' ' + this.label();
}
var labelKey = 'telemetry_label_' + this.id();
@@ -1263,7 +1255,7 @@ TableRow.prototype.markupForRun = function(result, referenceResult) {
if (isNaN(result.confidenceIntervalDeltaRatio())) {
// Don't bother showing +- Nan as it is meaningless
confidence = '';
- } else {
+ } else {
confidence = '± ' + formatPercentage(result.confidenceIntervalDeltaRatio());
}
@@ -1309,7 +1301,7 @@ TableRow.prototype.openRow = function() {
var child = this.children[0];
if (child.isImportant) {
// ... and it is important (i.e. the summary row) just open it when
- // parent is opened to save needless clicking
+ // parent is opened to save needless clicking
child.openRow();
}
}
« no previous file with comments | « no previous file | tools/telemetry/telemetry/TELEMETRY_DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698