Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1178843003: Use benchmark_name (date-time) instead of revision number for telemetry html (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use benchmark_name (date-time) instead of revision number for telemetry html results. Chromium src revision number doesn't work when telemetry is moved to catapult and is not that useful anyway. After this patch, results.html will look like this: http://i.imgur.com/FdNXkkH.png BUG=497905 Committed: https://crrev.com/27e4e3e9c965a73dfe735d1620a26ff1cf5ace2f Cr-Commit-Position: refs/heads/master@{#334609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M tools/telemetry/support/html_output/results-template.html View 3 chunks +4 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/results/html_output_formatter.py View 3 chunks +17 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py View 10 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nednguyen
5 years, 6 months ago (2015-06-12 19:09:49 UTC) #2
nednguyen
5 years, 6 months ago (2015-06-16 00:42:23 UTC) #4
sullivan
lgtm
5 years, 6 months ago (2015-06-16 05:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178843003/1
5 years, 6 months ago (2015-06-16 14:47:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 15:44:32 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 15:45:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e4e3e9c965a73dfe735d1620a26ff1cf5ace2f
Cr-Commit-Position: refs/heads/master@{#334609}

Powered by Google App Engine
This is Rietveld 408576698