Adds support for webrtc::test::ResourcePath on iOS

webrtc/test/testsupport/fileutils.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 20 matching lines @@
 #ifndef S_ISDIR  // Not defined in stat.h on Windows.
 #define S_ISDIR(mode) (((mode) & S_IFMT) == S_IFDIR)
 #endif
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "webrtc/typedefs.h"  // For architecture defines
 
+#if defined(WEBRTC_IOS)
+// Defined in iosfileutils.mm.  No header file to discourage use elsewhere.
+std::string IOSResourcePath(std::string name, std::string extension);
+#endif
+
 namespace webrtc {
 namespace test {
 
 namespace {
 
 #ifdef WIN32
 const char* kPathDelimiter = "\\";
 #else
 const char* kPathDelimiter = "/";
 #endif
@@ skipping 147 matching lines @@
 #ifdef WIN32
     return _mkdir(directory_name.c_str()) == 0;
 #else
     return mkdir(directory_name.c_str(),  S_IRWXU | S_IRWXG | S_IRWXO) == 0;
 #endif
   }
   return true;
 }
 
 std::string ResourcePath(std::string name, std::string extension) {
+#if defined (WEBRTC_IOS)
+  return IOSResourcePath(name, extension);

[henrika_webrtc, 2015/06/11 11:02:34]

I should add comments here about what's unique for iOS. File is placed in root
of app bundle etc.

[tkchin_webrtc, 2015/06/12 01:30:26]

Probably add it to header file function comments.
Will this cause compiler warning that rest of code is unreachable?

[henrika_webrtc, 2015/06/12 12:52:11]

I followed the existing style in unixfilesystem.cc in webrtc/base where an
mm-file is used without header. There are now compile warnings as is. Will add
comments in mm file. Not sure how to mix include and import.

[tkchin_webrtc, 2015/06/12 17:43:35]

What compiler warnings are you referring to? I meant that because rest of code
isn't ifdef-ed out, you get something that looks like

  return ...;
  std::string resources_path = ...;
  ...
  return resources_path + name + "." + extension.

The style of private extern makes sense to me. I would namespace the function
under webrtc::test though.

[henrika_webrtc, 2015/06/15 08:46:29]

Bad spelling in first version, I did *not* get any compile warnings. But see
your point. Did changes.

+#endif  // defined (WEBRTC_IOS)
+
   std::string platform = "win";
 #ifdef WEBRTC_LINUX
   platform = "linux";
 #endif  // WEBRTC_LINUX
 #ifdef WEBRTC_MAC
   platform = "mac";
 #endif  // WEBRTC_MAC
 
 #ifdef WEBRTC_ARCH_64_BITS
   std::string architecture = "64";
@@ skipping 30 matching lines @@
     if (fseek(f, 0, SEEK_END) == 0) {
       size = ftell(f);
     }
     fclose(f);
   }
   return size;
 }
 
 }  // namespace test
 }  // namespace webrtc