Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1178823003: Precompile Document.h and LayoutObject.h for Source/web

Created:
5 years, 6 months ago by Daniel Bratell
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, jam, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Precompile Document.h and LayoutObject.h for Source/web One reason Blink is slow to compile is that there is a lot of code included in every compilation unit since everything depends on either LayoutObject.h or Document.h and those in turn include huge portions of the rest of Blink. By precompiling LayoutObject.h and Document.h the compilation of core and modules in Blink can be several times faster. The downside is that it will introduce Document.h and LayoutObject.h also in compilation units that didn't expect it or wanted it. BUG=495697 R=thakis@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased to newer master #

Patch Set 3 : Implemented sof's suggestion #

Patch Set 4 : Slight clean up. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/web/WebKit.cpp View 1 3 chunks +3 lines, -3 lines 2 comments Download
M Source/web/tests/WebUnitTests.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/web.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
sof
https://codereview.chromium.org/1178823003/diff/1/Source/web/tests/WebUnitTests.cpp File Source/web/tests/WebUnitTests.cpp (right): https://codereview.chromium.org/1178823003/diff/1/Source/web/tests/WebUnitTests.cpp#newcode33 Source/web/tests/WebUnitTests.cpp:33: If #undef FROM_HERE is added here, the expected FROM_HERE ...
5 years, 6 months ago (2015-06-25 07:05:21 UTC) #1
Daniel Bratell
thakis, this is the last of the three major parts of Blink that can benefit ...
5 years, 5 months ago (2015-07-14 16:36:18 UTC) #3
sof
lgtm (but no web/ owner)
5 years, 5 months ago (2015-07-16 07:39:12 UTC) #5
sof
Local numbers: 13:10 to rebuild(*) Blink ToT; 09:55 with this CL. * - triggered by ...
5 years, 5 months ago (2015-07-16 13:04:51 UTC) #6
Daniel Bratell
Jochen, could you take a look please? It's about expanding the precompiling to one more ...
5 years, 5 months ago (2015-07-16 13:40:05 UTC) #8
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1178823003/diff/60001/Source/web/WebKit.cpp File Source/web/WebKit.cpp (right): https://codereview.chromium.org/1178823003/diff/60001/Source/web/WebKit.cpp#newcode70 Source/web/WebKit.cpp:70: namespace helpers { why this change?
5 years, 5 months ago (2015-07-16 13:46:55 UTC) #9
Daniel Bratell
https://codereview.chromium.org/1178823003/diff/60001/Source/web/WebKit.cpp File Source/web/WebKit.cpp (right): https://codereview.chromium.org/1178823003/diff/60001/Source/web/WebKit.cpp#newcode70 Source/web/WebKit.cpp:70: namespace helpers { On 2015/07/16 13:46:54, jochen wrote: > ...
5 years, 5 months ago (2015-07-16 13:57:12 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-16 13:58:57 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 14:13:00 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698