When starting a provisional load, indicate whether the provisional URL is about:srcdoc

When starting a provisional load, indicate whether the provisional URL is about:srcdoc

This corresponds to an iframe loading the document given in its srcdoc attribute

BUG=143337
R=creis@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175396

[Charlie Reis, 2013-01-07 19:14:04]

One question-- are all three CLs necessary to fix the crash in 143337, or is the
first one sufficient (changing the URL to about:blank), and these next two are
needed to expose about:srcdoc in the extension API?  If that's the case, can you
file a separate bug for the these two?  (That will help keep things separate if
we need to merge the simplest crash fix, for example.)

Otherwise, LGTM.

[jochen (gone - plz use gerrit), 2013-01-07 19:18:48]

On 2013/01/07 19:14:04, creis wrote:
> One question-- are all three CLs necessary to fix the crash in 143337, or is
the
> first one sufficient (changing the URL to about:blank), and these next two are
> needed to expose about:srcdoc in the extension API?  If that's the case, can
you
> file a separate bug for the these two?  (That will help keep things separate
if
> we need to merge the simplest crash fix, for example.)

It's not really a crash, it's a DCHECK() triggering I left there on purpose to
get alerts (via bug reports) if my logic disagrees with the implementation :)

I could file a separate bug for the missing FilterURL calls in WCI as this is a
somewhat generic issue I discovered while debugging this.

> 
> Otherwise, LGTM.

[Charlie Reis, 2013-01-07 19:27:30]

On 2013/01/07 19:18:48, jochen wrote:
> It's not really a crash, it's a DCHECK() triggering I left there on purpose to
> get alerts (via bug reports) if my logic disagrees with the implementation :)
> 
> I could file a separate bug for the missing FilterURL calls in WCI as this is
a
> somewhat generic issue I discovered while debugging this.

Works for me.  Thanks.

[commit-bot: I haz the power, 2013-01-07 20:45:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11788015/1

[commit-bot: I haz the power, 2013-01-07 22:06:34]

Change committed as 175396