Issue 11788007: While building the system menu for the Chrome browser frame we should add the separator after the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11788007: While building the system menu for the Chrome browser frame we should add the separator after the (Closed)

Created:
7 years, 11 months ago by ananta

Modified:
7 years, 11 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

While building the system menu for the Chrome browser frame we should add the separator after the TaskManager option only if the TaskManager option was added to the menu in the first place. This causes a DCHECK for consecutive separators to fire on Chrome Windows 8 metro which does not have the TaskManager option in the menu. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175245

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/frame/browser_frame_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages