content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java - Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tweaks Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

index 64322b062f2d11ec83b9011a46eb9a824a60c5f1..2b7230792906c68f83b4fa9519899ca12acc0014 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

@@ -35,16 +35,11 @@ public class TestContentViewClient extends ContentViewClient {

}

/**

- * ATTENTION!: When overriding the following methods, be sure to call

- * the corresponding methods in the super class. Otherwise

+ * ATTENTION!: When overriding the following method, be sure to call

+ * the corresponding method in the super class. Otherwise

* {@link CallbackHelper#waitForCallback()} methods will

* stop working!

- @Override

- public void onEvaluateJavaScriptResult(int id, String jsonResult) {

- super.onEvaluateJavaScriptResult(id, jsonResult);

- mOnEvaluateJavaScriptResultHelper.notifyCalled(id, jsonResult);

- }

@Override

public void onStartContentIntent(Context context, String contentUrl) {