Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new approach with Messages Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
index 27b937a39f6754ca0b3d25d89fe6565cd1cb1197..bb1d2f4e9b6b8ffef7ef3d0a1cf1e31b27bf4066 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
@@ -423,13 +423,12 @@ public class ContentView extends FrameLayout implements ContentViewCore.Internal
* ContentViewClient.onJavaScriptEvaluationResult is made. Used in automation
* tests.
*
- * @return an id that is passed along in the asynchronous onJavaScriptEvaluationResult callback
* @throws IllegalStateException If the ContentView has been destroyed.
*
* TODO(nileshagrawal): Remove this method from the public interface.
*/
- public int evaluateJavaScript(String script) throws IllegalStateException {
- return mContentViewCore.evaluateJavaScript(script);
+ public void evaluateJavaScript(String script) throws IllegalStateException {
+ mContentViewCore.evaluateJavaScript(script, null);
}
/**

Powered by Google App Engine
This is Rietveld 408576698