Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new approach with Messages Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 111e0d3b3334f814c7c8aaa179216ad4fd1c0472..9899a177f52b92e046e6a256fdc2fc47da7f67c7 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -24,6 +24,10 @@
struct WebMenuItem;
+namespace base {
+class Value;
+}
+
namespace ui {
class WindowAndroid;
}
@@ -156,7 +160,10 @@ class ContentViewCoreImpl : public ContentViewCore,
void ContinuePendingReload(JNIEnv* env, jobject obj);
jboolean NeedsReload(JNIEnv* env, jobject obj);
void ClearHistory(JNIEnv* env, jobject obj);
- jint EvaluateJavaScript(JNIEnv* env, jobject obj, jstring script);
+ void EvaluateJavaScript(JNIEnv* env,
+ jobject obj,
+ jstring script,
+ jobject message);
int GetNativeImeAdapter(JNIEnv* env, jobject obj);
void SetFocus(JNIEnv* env, jobject obj, jboolean focused);
void ScrollFocusedEditableNodeIntoView(JNIEnv* env, jobject obj);
@@ -259,6 +266,10 @@ class ContentViewCoreImpl : public ContentViewCore,
const NotificationSource& source,
const NotificationDetails& details) OVERRIDE;
+ // Notification that Javascript execution is complete.
joth 2013/01/05 00:54:42 probably should be in "Other private methods and
Avi (use Gerrit) 2013/01/05 01:03:34 Done.
+ void JavaScriptResultCallback(ScopedJavaGlobalRef<jobject>* message,
+ const base::Value* result);
+
// --------------------------------------------------------------------------
// Other private methods and data
// --------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698