 Chromium Code Reviews
 Chromium Code Reviews Issue 11788005:
  Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 11788005:
  Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java | 
| diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java | 
| index 64322b062f2d11ec83b9011a46eb9a824a60c5f1..2b7230792906c68f83b4fa9519899ca12acc0014 100644 | 
| --- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java | 
| +++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java | 
| @@ -35,16 +35,11 @@ public class TestContentViewClient extends ContentViewClient { | 
| } | 
| /** | 
| - * ATTENTION!: When overriding the following methods, be sure to call | 
| - * the corresponding methods in the super class. Otherwise | 
| + * ATTENTION!: When overriding the following method, be sure to call | 
| + * the corresponding method in the super class. Otherwise | 
| * {@link CallbackHelper#waitForCallback()} methods will | 
| * stop working! | 
| */ | 
| 
mkosiba (inactive)
2013/01/07 10:42:09
why did you leave the comment?
 
Avi (use Gerrit)
2013/01/07 15:10:26
It said "methods" so I thought that it was referri
 
mkosiba (inactive)
2013/01/07 15:37:12
yes it does. my mistake.
 | 
| - @Override | 
| - public void onEvaluateJavaScriptResult(int id, String jsonResult) { | 
| - super.onEvaluateJavaScriptResult(id, jsonResult); | 
| - mOnEvaluateJavaScriptResultHelper.notifyCalled(id, jsonResult); | 
| - } | 
| @Override | 
| public void onStartContentIntent(Context context, String contentUrl) { |