android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java - Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 11788005: Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: the findbugs the Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

index f979d9906a36bdb696648cf062446ed3c44c5076..c76989703f8e0f46cea9ffe7b70ba8f6073e62e4 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

@@ -73,12 +73,6 @@ class TestAwContentsClient extends NullContentsClient {

}

@Override

- public void onEvaluateJavaScriptResult(int id, String jsonResult) {

- super.onEvaluateJavaScriptResult(id, jsonResult);

- mOnEvaluateJavaScriptResultHelper.notifyCalled(id, jsonResult);

- }

- @Override

public boolean onConsoleMessage(ConsoleMessage consoleMessage) {

mAddMessageToConsoleHelper.setLevel(consoleMessage.messageLevel().ordinal());

mAddMessageToConsoleHelper.setMessage(consoleMessage.message());