Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1178733005: SMIL animation should only progress() on active documents (Closed)

Created:
4 years, 10 months ago by kouhei (in TOK)
Modified:
4 years, 10 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, shans, rjwright, blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, krit, f(malita), darktears, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SMIL animation should only progress() on active documents Before this patch, SMIL animation made progress on about-to-be destroyed documents, where it didn't make sense. This caused internal ASSERTs to hiccup on cases where Blink timer was used to service next animation frame, and the timer event was processed after document lifecycle has progressed to Stopping or Stopped state. This patch ensures that SMIL animations to only progress() on active documents. BUG=470409 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
A LayoutTests/svg/animations/smil-scheduled-in-inactive-document-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/smil-scheduled-in-inactive-document-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kouhei (in TOK)
4 years, 10 months ago (2015-06-18 21:17:14 UTC) #2
fs
LGTM (that is one subtle TC BTW...)
4 years, 10 months ago (2015-06-18 23:22:35 UTC) #3
kouhei (in TOK)
On 2015/06/18 23:22:35, fs wrote: > LGTM (that is one subtle TC BTW...) Sorry I ...
4 years, 10 months ago (2015-06-18 23:51:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178733005/1
4 years, 10 months ago (2015-06-18 23:52:38 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 01:30:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197415

Powered by Google App Engine
This is Rietveld 408576698