Fix -INT_MIN integer overflow in string_number_conversions.cc.

Fix -INT_MIN integer overflow in string_number_conversions.cc.

BUG=None

Committed: https://crrev.com/d134e357dc14978863efe22c9350e2a8ff7131b3
Cr-Commit-Position: refs/heads/master@{#335912}

[Thiemo Nagel, 2015-06-17 13:26:04]

tnagel@chromium.org changed reviewers:
+ brettw@chromium.org

[Thiemo Nagel, 2015-06-17 13:26:04]

Hi Brett,

could you please take a look?

Thank you,
Thiemo

[brettw, 2015-06-19 18:08:07]

Good find. Can we get a unit tests for this case?

[Thiemo Nagel, 2015-06-23 09:20:05]

On 2015/06/19 18:08:07, brettw wrote:
> Good find. Can we get a unit tests for this case?

This is already covered by the StringNumberConversionsTest.IntToString test
(-9223372036854775808).  The test succeeds because although the calculation is
undefined it yields the expected results (at least for the combination of
compiler and architecture that we run unit tests on).

[brettw, 2015-06-23 16:51:53]

lgtm

[Thiemo Nagel, 2015-06-23 16:56:27]

On 2015/06/23 16:51:53, brettw wrote:
> lgtm

Thank you!

[Thiemo Nagel, 2015-06-23 16:56:30]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2015-06-23 16:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178733004/20001

[commit-bot: I haz the power, 2015-06-23 17:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 17:24:20]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Thiemo Nagel, 2015-06-23 18:20:39]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2015-06-23 18:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178733004/20001

[commit-bot: I haz the power, 2015-06-23 20:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 20:43:18]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Thiemo Nagel, 2015-06-24 12:53:26]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2015-06-24 12:53:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178733004/20001

[commit-bot: I haz the power, 2015-06-24 13:51:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-24 13:52:17]

Patchset 2 (id:??) landed as
https://crrev.com/d134e357dc14978863efe22c9350e2a8ff7131b3
Cr-Commit-Position: refs/heads/master@{#335912}