Issue 11787038: google_apis: Implement some functions in FakeDriveService

Issue 11787038: google_apis: Implement some functions in FakeDriveService (Closed)

Created:
7 years, 11 months ago by satorux1

Modified:
7 years, 11 months ago

Reviewers:
Lei Zhang, kinaba

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Implement some functions in FakeDriveService Implement GetResourceList, GetAccountMetadata, GetResourceEntry, and DeleteResource. BUG=162350 TEST=none; no changes in production code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175716

Patch Set 1 #

Total comments: 5

Patch Set 2 : address comments #

Patch Set 3 : Exclude the test on Android #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -0 lines)			Patch
M	chrome/browser/google_apis/fake_drive_service.h	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/google_apis/fake_drive_service.cc	View	1	5 chunks	+105 lines, -0 lines	0 comments	Download
A	chrome/browser/google_apis/fake_drive_service_unittest.cc	View		1 chunk	+148 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fake_drive_service.cc File chrome/browser/google_apis/fake_drive_service.cc (right): https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fake_drive_service.cc#newcode37 chrome/browser/google_apis/fake_drive_service.cc:37: resource_list_value_.reset(feed_as_dict); Is this safe? |feed_as_dict| looks to be simultaneously ...

7 years, 11 months ago (2013-01-08 08:26:53 UTC) #2

satorux1

https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fake_drive_service.cc File chrome/browser/google_apis/fake_drive_service.cc (right): https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fake_drive_service.cc#newcode37 chrome/browser/google_apis/fake_drive_service.cc:37: resource_list_value_.reset(feed_as_dict); On 2013/01/08 08:26:53, kinaba wrote: > Is this ...

7 years, 11 months ago (2013-01-09 00:50:49 UTC) #4

kinaba

7 years, 11 months ago (2013-01-09 01:36:22 UTC) #5

lgtm

https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/11787038/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service.cc:37:
resource_list_value_.reset(feed_as_dict);
On 2013/01/09 00:50:49, satorux1 wrote:
> On 2013/01/08 08:26:53, kinaba wrote:
> > Is this safe? |feed_as_dict| looks to be simultaneously owned by |raw_value|
> and
> > |resource_list_value_|.
> 
> Should be safe. Remove() above transfers the ownership to |feed|. Added a
> comment.

Ah, sorry, you're right.

Expand Messages | Collapse Messages