Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1178703010: Add elapsed time and timeout value to feedback data. (Closed)

Created:
5 years, 6 months ago by nyquist
Modified:
5 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add elapsed time and timeout value to feedback data. To help identifying issues with the connectivity feedback data, this CL adds data about timeouts and the elapsed time before the data was gathered. Some of the flows where this data is used, there is a very short or no delay between starting the connectivity checks and gathering the results so this should help identify such cases. BUG=386395 Committed: https://crrev.com/94cf3373f7a8d3d40f47be0f25bd0f30275a38d2 Cr-Commit-Position: refs/heads/master@{#334084}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary change to EnumMap creation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java View 1 6 chunks +52 lines, -3 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollectorTest.java View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nyquist
dfalcantara: PTAL
5 years, 6 months ago (2015-06-11 18:59:23 UTC) #2
gone
On 2015/06/11 18:59:23, nyquist wrote: > dfalcantara: PTAL Remove the @deprecated in this CL?
5 years, 6 months ago (2015-06-11 20:21:38 UTC) #3
gone
lgtm https://codereview.chromium.org/1178703010/diff/1/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java File chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java (right): https://codereview.chromium.org/1178703010/diff/1/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java#newcode109 chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java:109: private final Map<Type, Result> mResult = new EnumMap<>(Type.class); ...
5 years, 6 months ago (2015-06-11 20:26:08 UTC) #4
nyquist
https://codereview.chromium.org/1178703010/diff/1/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java File chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java (right): https://codereview.chromium.org/1178703010/diff/1/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java#newcode109 chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerCollector.java:109: private final Map<Type, Result> mResult = new EnumMap<>(Type.class); On ...
5 years, 6 months ago (2015-06-11 23:09:49 UTC) #5
nyquist
On 2015/06/11 20:21:38, dfalcantara wrote: > On 2015/06/11 18:59:23, nyquist wrote: > > dfalcantara: PTAL ...
5 years, 6 months ago (2015-06-11 23:10:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178703010/20001
5 years, 6 months ago (2015-06-11 23:10:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 23:45:43 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 23:46:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94cf3373f7a8d3d40f47be0f25bd0f30275a38d2
Cr-Commit-Position: refs/heads/master@{#334084}

Powered by Google App Engine
This is Rietveld 408576698